2012-10-08 12:25:46

by YAMANE Toshiaki

Subject: [PATCH] staging/comedi: Use dev_ printks in drivers/usbdux.c

fixed below checkpatch warning.
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...

Signed-off-by: YAMANE Toshiaki <[email protected]>
---
drivers/staging/comedi/drivers/usbdux.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
index b536bba..e89f4e2 100644
--- a/drivers/staging/comedi/drivers/usbdux.c
+++ b/drivers/staging/comedi/drivers/usbdux.c
@@ -2386,14 +2386,12 @@ static int usbdux_attach_usb(struct comedi_device *dev,
down(&start_stop_sem);
this_usbduxsub = usb_get_intfdata(uinterf);
if (!this_usbduxsub || !this_usbduxsub->probed) {
- printk(KERN_ERR
- "comedi%d: usbdux: error: attach_usb failed, not connected\n",
- dev->minor);
+ dev_err(dev->class_dev,
+ "usbdux: error: attach_usb failed, not connected\n");
ret = -ENODEV;
} else if (this_usbduxsub->attached) {
- printk(KERN_ERR
- "comedi%d: usbdux: error: attach_usb failed, already attached\n",
- dev->minor);
+ dev_err(dev->class_dev,
+ "error: attach_usb failed, already attached\n");
ret = -ENODEV;
} else
ret = usbdux_attach_common(dev, this_usbduxsub);
--
1.7.9.5

2012-10-14 13:38:16

by YAMANE Toshiaki

Subject: [PATCH] staging/comedi: Use dev_ printks in drivers/usbdux.c

fixed below checkpatch warning.
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...

Signed-off-by: YAMANE Toshiaki <[email protected]>
---
drivers/staging/comedi/drivers/usbdux.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
index b536bba..46c5bfb 100644
--- a/drivers/staging/comedi/drivers/usbdux.c
+++ b/drivers/staging/comedi/drivers/usbdux.c
@@ -2386,14 +2386,12 @@ static int usbdux_attach_usb(struct comedi_device *dev,
down(&start_stop_sem);
this_usbduxsub = usb_get_intfdata(uinterf);
if (!this_usbduxsub || !this_usbduxsub->probed) {
- printk(KERN_ERR
- "comedi%d: usbdux: error: attach_usb failed, not connected\n",
- dev->minor);
+ dev_err(&uinterf->dev,
+ "usbdux: error: attach_usb failed, not connected\n");
ret = -ENODEV;
} else if (this_usbduxsub->attached) {
- printk(KERN_ERR
- "comedi%d: usbdux: error: attach_usb failed, already attached\n",
- dev->minor);
+ dev_err(&uinterf->dev,
+ "error: attach_usb failed, already attached\n");
ret = -ENODEV;
} else
ret = usbdux_attach_common(dev, this_usbduxsub);
--
1.7.9.5

2012-10-14 13:51:56

by YAMANE Toshiaki

Subject: Re: [PATCH] staging/comedi: Use dev_ printks in drivers/usbdux.c

On Sun, Oct 14, 2012 at 10:38 PM, YAMANE Toshiaki <[email protected]> wrote:
> fixed below checkpatch warning.
> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
>
> Signed-off-by: YAMANE Toshiaki <[email protected]>
> ---
> drivers/staging/comedi/drivers/usbdux.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
> index b536bba..46c5bfb 100644
> --- a/drivers/staging/comedi/drivers/usbdux.c
> +++ b/drivers/staging/comedi/drivers/usbdux.c
> @@ -2386,14 +2386,12 @@ static int usbdux_attach_usb(struct comedi_device *dev,
> down(&start_stop_sem);
> this_usbduxsub = usb_get_intfdata(uinterf);
> if (!this_usbduxsub || !this_usbduxsub->probed) {
> - printk(KERN_ERR
> - "comedi%d: usbdux: error: attach_usb failed, not connected\n",
> - dev->minor);
> + dev_err(&uinterf->dev,
> + "usbdux: error: attach_usb failed, not connected\n");
> ret = -ENODEV;
> } else if (this_usbduxsub->attached) {
> - printk(KERN_ERR
> - "comedi%d: usbdux: error: attach_usb failed, already attached\n",
> - dev->minor);
> + dev_err(&uinterf->dev,
> + "error: attach_usb failed, already attached\n");
> ret = -ENODEV;
> } else
> ret = usbdux_attach_common(dev, this_usbduxsub);
> --
> 1.7.9.5
>

I cannot judge which is better or not ...

--

Regards,

YAMANE Toshiaki