2012-10-19 22:08:12

by rrl125

[permalink] [raw]
Subject: Re: x2apic boot failure on recent sandy bridge system

Any update? The messages just seem to have stopped months ago. A fallback would be nice, I have been booting the kernel with noa2xpic for since kernel 3.2, and currently I am working with 3.6.2.

If needed I can try to attempt modifying the patch to include fallback, but I am probably not the best person to do it.

On Sunday, December 18, 2011 3:49:27 AM UTC-5, Ingo Molnar wrote:
> * Berck E. Nash <[email protected]> wrote:
>
>
>
> > On 12/12/2011 10:13 PM, Yinghai Lu wrote:
>
> > > please check -v7.
>
> >
>
> > Works just fine for me.
>
>
>
> That's interesting.
>
>
>
> Now if this could be made completely automatic (no extra
>
> parameter passing), then we have a usable fallback mode - which
>
> is preferred to crashing the box.
>
>
>
> Thanks,
>
>
>
> Ingo
>
> --
>
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>
> the body of a message to [email protected]
>
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Please read the FAQ at http://www.tux.org/lkml/


2012-10-19 23:02:13

by Suresh Siddha

[permalink] [raw]
Subject: Re: x2apic boot failure on recent sandy bridge system

On Fri, 2012-10-19 at 13:42 -0700, [email protected] wrote:
> Any update? The messages just seem to have stopped months ago. A
> fallback would be nice, I have been booting the kernel with noa2xpic
> for since kernel 3.2, and currently I am working with 3.6.2.
>
> If needed I can try to attempt modifying the patch to include
> fallback, but I am probably not the best person to do it.
>

Are you referring to this commit that made into the mainline tree
already?

commit fb209bd891645bb87b9618b724f0b4928e0df3de
Author: Yinghai Lu <[email protected]>
Date: Wed Dec 21 17:45:17 2011 -0800

x86, x2apic: Fallback to xapic when BIOS doesn't setup interrupt-remapping

On some of the recent Intel SNB platforms, by default bios is pre-enabling
x2apic mode in the cpu with out setting up interrupt-remapping.
This case was resulting in the kernel to panic as the cpu is already in
x2apic mode but the OS was not able to enable interrupt-remapping (which
is a pre-req for using x2apic capability).

On these platforms all the apic-ids are < 255 and the kernel can fallback to
xapic mode if the bios has not enabled interrupt-remapping (which is
mostly the case if the bios has not exported interrupt-remapping tables to the
OS).

Reported-by: Berck E. Nash <[email protected]>
Signed-off-by: Yinghai Lu <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Suresh Siddha <[email protected]>
Signed-off-by: H. Peter Anvin <[email protected]>

2012-10-19 23:32:41

by Yinghai Lu

[permalink] [raw]
Subject: Re: x2apic boot failure on recent sandy bridge system

On Fri, Oct 19, 2012 at 4:03 PM, Suresh Siddha
<[email protected]> wrote:
> On Fri, 2012-10-19 at 13:42 -0700, [email protected] wrote:
>> Any update? The messages just seem to have stopped months ago. A
>> fallback would be nice, I have been booting the kernel with noa2xpic
>> for since kernel 3.2, and currently I am working with 3.6.2.
>>
>> If needed I can try to attempt modifying the patch to include
>> fallback, but I am probably not the best person to do it.
>>
>
> Are you referring to this commit that made into the mainline tree
> already?
>
> commit fb209bd891645bb87b9618b724f0b4928e0df3de
> Author: Yinghai Lu <[email protected]>
> Date: Wed Dec 21 17:45:17 2011 -0800
>
> x86, x2apic: Fallback to xapic when BIOS doesn't setup interrupt-remapping

I think his system has DMAR table and cpu support x2apic, So kernel
will switch to x2apic,

but somehow BIOS SMI handler has problem with x2apic. should be thinkpad W520?

2012-10-19 23:36:56

by H. Peter Anvin

[permalink] [raw]
Subject: Re: x2apic boot failure on recent sandy bridge system

On 10/19/2012 04:32 PM, Yinghai Lu wrote:
> On Fri, Oct 19, 2012 at 4:03 PM, Suresh Siddha
> <[email protected]> wrote:
>> On Fri, 2012-10-19 at 13:42 -0700, [email protected] wrote:
>>> Any update? The messages just seem to have stopped months ago. A
>>> fallback would be nice, I have been booting the kernel with noa2xpic
>>> for since kernel 3.2, and currently I am working with 3.6.2.
>>>
>>> If needed I can try to attempt modifying the patch to include
>>> fallback, but I am probably not the best person to do it.
>>>
>>
>> Are you referring to this commit that made into the mainline tree
>> already?
>>
>> commit fb209bd891645bb87b9618b724f0b4928e0df3de
>> Author: Yinghai Lu <[email protected]>
>> Date: Wed Dec 21 17:45:17 2011 -0800
>>
>> x86, x2apic: Fallback to xapic when BIOS doesn't setup interrupt-remapping
>
> I think his system has DMAR table and cpu support x2apic, So kernel
> will switch to x2apic,
>
> but somehow BIOS SMI handler has problem with x2apic. should be thinkpad W520?
>

Right, StinkPad W520 needs a quirk.


--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

2012-10-20 00:00:28

by Suresh Siddha

[permalink] [raw]
Subject: Re: x2apic boot failure on recent sandy bridge system

On Fri, 2012-10-19 at 16:36 -0700, H. Peter Anvin wrote:
> On 10/19/2012 04:32 PM, Yinghai Lu wrote:
> > On Fri, Oct 19, 2012 at 4:03 PM, Suresh Siddha
> > <[email protected]> wrote:
> >> On Fri, 2012-10-19 at 13:42 -0700, [email protected] wrote:
> >>> Any update? The messages just seem to have stopped months ago. A
> >>> fallback would be nice, I have been booting the kernel with noa2xpic
> >>> for since kernel 3.2, and currently I am working with 3.6.2.
> >>>
> >>> If needed I can try to attempt modifying the patch to include
> >>> fallback, but I am probably not the best person to do it.
> >>>
> >>
> >> Are you referring to this commit that made into the mainline tree
> >> already?
> >>
> >> commit fb209bd891645bb87b9618b724f0b4928e0df3de
> >> Author: Yinghai Lu <[email protected]>
> >> Date: Wed Dec 21 17:45:17 2011 -0800
> >>
> >> x86, x2apic: Fallback to xapic when BIOS doesn't setup interrupt-remapping
> >
> > I think his system has DMAR table and cpu support x2apic, So kernel
> > will switch to x2apic,
> >
> > but somehow BIOS SMI handler has problem with x2apic. should be thinkpad W520?
> >
>
> Right, StinkPad W520 needs a quirk.

yes. Yinghai, if you remember you had a T420 that didn't show the
problem. And someone in the bugzilla with T420 had the problem. And
their dmidecode is
https://launchpadlibrarian.net/109393850/dmidecode.txt

What is the difference with your system? Bios I think is the same.

Can you see what we should check for in the dmi tables to black list
these systems? Can you post your T420's dmidecode to see the difference.

Bugs I have on this are:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/776999
https://bugzilla.kernel.org/show_bug.cgi?id=43054

thanks,
suresh

2012-10-20 00:41:52

by Yinghai Lu

[permalink] [raw]
Subject: Re: x2apic boot failure on recent sandy bridge system

On Fri, Oct 19, 2012 at 5:02 PM, Suresh Siddha
<[email protected]> wrote:
> On Fri, 2012-10-19 at 16:36 -0700, H. Peter Anvin wrote:
>> On 10/19/2012 04:32 PM, Yinghai Lu wrote:
>> > On Fri, Oct 19, 2012 at 4:03 PM, Suresh Siddha
>> > <[email protected]> wrote:
>> >> On Fri, 2012-10-19 at 13:42 -0700, [email protected] wrote:
>> >>> Any update? The messages just seem to have stopped months ago. A
>> >>> fallback would be nice, I have been booting the kernel with noa2xpic
>> >>> for since kernel 3.2, and currently I am working with 3.6.2.
>> >>>
>> >>> If needed I can try to attempt modifying the patch to include
>> >>> fallback, but I am probably not the best person to do it.
>> >>>
>> >>
>> >> Are you referring to this commit that made into the mainline tree
>> >> already?
>> >>
>> >> commit fb209bd891645bb87b9618b724f0b4928e0df3de
>> >> Author: Yinghai Lu <[email protected]>
>> >> Date: Wed Dec 21 17:45:17 2011 -0800
>> >>
>> >> x86, x2apic: Fallback to xapic when BIOS doesn't setup interrupt-remapping
>> >
>> > I think his system has DMAR table and cpu support x2apic, So kernel
>> > will switch to x2apic,
>> >
>> > but somehow BIOS SMI handler has problem with x2apic. should be thinkpad W520?
>> >
>>
>> Right, StinkPad W520 needs a quirk.
>
> yes. Yinghai, if you remember you had a T420 that didn't show the
> problem. And someone in the bugzilla with T420 had the problem. And
> their dmidecode is
> https://launchpadlibrarian.net/109393850/dmidecode.txt
>
> What is the difference with your system? Bios I think is the same.

1.37 was working too, i updated it to 1.39 and it is still working.

>
> Can you see what we should check for in the dmi tables to black list
> these systems? Can you post your T420's dmidecode to see the difference.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=43054

post dmesg and dmidecode to that bug report.

Thanks

Yinghai