LinuxLists.cc - [PATCH RFT] hexagon: dma-mapping: support debug_dma_mapping

2012-10-25 23:12:18

Subject: [PATCH RFT] hexagon: dma-mapping: support debug_dma_mapping_error

Add support for debug_dma_mapping_error() call to avoid warning from
debug_dma_unmap() interface when it checks for mapping error checked
status. Without this patch, device driver failed to check map error
warning is generated.

Signed-off-by: Shuah Khan <[email protected]>
---
arch/hexagon/include/asm/dma-mapping.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/hexagon/include/asm/dma-mapping.h b/arch/hexagon/include/asm/dma-mapping.h
index 85e9935..1957c4c 100644
--- a/arch/hexagon/include/asm/dma-mapping.h
+++ b/arch/hexagon/include/asm/dma-mapping.h
@@ -65,6 +65,7 @@ static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
{
struct dma_map_ops *dma_ops = get_dma_ops(dev);

+ debug_dma_mapping_error(dev, dma_addr);
if (dma_ops->mapping_error)
return dma_ops->mapping_error(dev, dma_addr);

--
1.7.9.5

2012-10-26 15:43:22

by Shuah Khan

[permalink] [raw]

Subject: [PATCH RFT RESEDN linux-next] hexagon: dma-mapping: support debug_dma_mapping_error

2012-11-02 16:48:26

by Shuah Khan

[permalink] [raw]

Subject: Re: [PATCH RFT RESEND linux-next] hexagon: dma-mapping: support debug_dma_mapping_error

On Fri, 2012-10-26 at 09:43 -0600, Shuah Khan wrote:
> Add support for debug_dma_mapping_error() call to avoid warning from
> debug_dma_unmap() interface when it checks for mapping error checked
> status. Without this patch, device driver failed to check map error
> warning is generated.
>
> Signed-off-by: Shuah Khan <[email protected]>
> ---
> arch/hexagon/include/asm/dma-mapping.h | 1 +
> 1 file changed, 1 insertion(+)

Would you like se this patch go through arch tree or linux-next? Please
let me know your preference.

-- Shuah
>
> diff --git a/arch/hexagon/include/asm/dma-mapping.h b/arch/hexagon/include/asm/dma-mapping.h
> index 85e9935..1957c4c 100644
> --- a/arch/hexagon/include/asm/dma-mapping.h
> +++ b/arch/hexagon/include/asm/dma-mapping.h
> @@ -65,6 +65,7 @@ static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
> {
> struct dma_map_ops *dma_ops = get_dma_ops(dev);
>
> + debug_dma_mapping_error(dev, dma_addr);
> if (dma_ops->mapping_error)
> return dma_ops->mapping_error(dev, dma_addr);
>

2012-11-05 01:09:23

by Richard Kuo

[permalink] [raw]

Subject: Re: [PATCH RFT RESEND linux-next] hexagon: dma-mapping: support debug_dma_mapping_error

On Fri, Nov 02, 2012 at 10:48:21AM -0600, Shuah Khan wrote:
> On Fri, 2012-10-26 at 09:43 -0600, Shuah Khan wrote:
> > Add support for debug_dma_mapping_error() call to avoid warning from
> > debug_dma_unmap() interface when it checks for mapping error checked
> > status. Without this patch, device driver failed to check map error
> > warning is generated.
> >
> > Signed-off-by: Shuah Khan <[email protected]>
> > ---
> > arch/hexagon/include/asm/dma-mapping.h | 1 +
> > 1 file changed, 1 insertion(+)
>
> Would you like se this patch go through arch tree or linux-next? Please
> let me know your preference.
>
> -- Shuah
> >
> > diff --git a/arch/hexagon/include/asm/dma-mapping.h b/arch/hexagon/include/asm/dma-mapping.h
> > index 85e9935..1957c4c 100644
> > --- a/arch/hexagon/include/asm/dma-mapping.h
> > +++ b/arch/hexagon/include/asm/dma-mapping.h
> > @@ -65,6 +65,7 @@ static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
> > {
> > struct dma_map_ops *dma_ops = get_dma_ops(dev);
> >
> > + debug_dma_mapping_error(dev, dma_addr);
> > if (dma_ops->mapping_error)
> > return dma_ops->mapping_error(dev, dma_addr);
> >
>
>

This looks fine; I'm OK with this going through linux-next. Thanks!

Acked-by: Richard Kuo <[email protected]>

--

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

2012-11-15 17:57:34

by Shuah Khan

[permalink] [raw]

Subject: Re: [PATCH RFT RESEND linux-next] hexagon: dma-mapping: support debug_dma_mapping_error

On Sun, 2012-11-04 at 19:08 -0600, Richard Kuo wrote:
> On Fri, Nov 02, 2012 at 10:48:21AM -0600, Shuah Khan wrote:
> > On Fri, 2012-10-26 at 09:43 -0600, Shuah Khan wrote:
> > > Add support for debug_dma_mapping_error() call to avoid warning from
> > > debug_dma_unmap() interface when it checks for mapping error checked
> > > status. Without this patch, device driver failed to check map error
> > > warning is generated.
> > >
> > > Signed-off-by: Shuah Khan <[email protected]>
> > > ---
> > > arch/hexagon/include/asm/dma-mapping.h | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > Would you like se this patch go through arch tree or linux-next? Please
> > let me know your preference.
> >
> > -- Shuah
> > >
> > > diff --git a/arch/hexagon/include/asm/dma-mapping.h b/arch/hexagon/include/asm/dma-mapping.h
> > > index 85e9935..1957c4c 100644
> > > --- a/arch/hexagon/include/asm/dma-mapping.h
> > > +++ b/arch/hexagon/include/asm/dma-mapping.h
> > > @@ -65,6 +65,7 @@ static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
> > > {
> > > struct dma_map_ops *dma_ops = get_dma_ops(dev);
> > >
> > > + debug_dma_mapping_error(dev, dma_addr);
> > > if (dma_ops->mapping_error)
> > > return dma_ops->mapping_error(dev, dma_addr);
> > >
> >
> >
>
> This looks fine; I'm OK with this going through linux-next. Thanks!
>
> Acked-by: Richard Kuo <[email protected]>
>

Marek,

This one is for hexagon to go through your tree with the other arch
patches for debug_dma_mapping_error().

Thanks,
-- Shuah