The comment above fw_file_size() suggests it is noinline for stack size
reasons. Use noinline_for_stack to make this more clear.
Cc: Ming Lei <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Linus Torvalds <[email protected]>
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
drivers/base/firmware_class.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 8945f4e..620b876 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -275,7 +275,7 @@ static const char *fw_path[] = {
};
/* Don't inline this: 'struct kstat' is biggish */
-static noinline long fw_file_size(struct file *file)
+static noinline_for_stack long fw_file_size(struct file *file)
{
struct kstat st;
if (vfs_getattr(file->f_path.mnt, file->f_path.dentry, &st))
--
1.7.11.7
On Sun, Oct 28, 2012 at 6:37 AM, Cesar Eduardo Barros <[email protected]> wrote:
> The comment above fw_file_size() suggests it is noinline for stack size
> reasons. Use noinline_for_stack to make this more clear.
Acked-by: Ming Lei <[email protected]>
Thanks,
--
Ming Lei
On Sun, 28 Oct 2012, Ming Lei wrote:
> > The comment above fw_file_size() suggests it is noinline for stack size
> > reasons. Use noinline_for_stack to make this more clear.
>
> Acked-by: Ming Lei <[email protected]>
Although I am not completely sure that documenting the purpose of noinline
through this attribute is the nicest thing to do, it's been acked by
maintainer and it's being used tree-wise, so I am taking this one.
Thanks,
--
Jiri Kosina
SUSE Labs