2012-10-31 11:06:53

by Philip, Avinash

Subject: [PATCH v3] ARM: dts: AM33xx: Add SPI node

Add McSPI data node to AM33XX device tree file. The McSPI module (and so
as the driver) is reused from OMAP4.

Signed-off-by: Philip, Avinash <[email protected]>
Tested-by: Matt Porter <[email protected]>
---
Changes since v2:
- Commit message corrected.
- Rebase on top of for_3.8/dts

Changes since v1:
- Corrected reg offset in reg DT entry.

:100644 100644 97a7bd3... 6e04789... M arch/arm/boot/dts/am33xx.dtsi
arch/arm/boot/dts/am33xx.dtsi | 24 ++++++++++++++++++++++++
1 files changed, 24 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 97a7bd3..6e04789 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -299,5 +299,29 @@
76>;
ti,hwmods = "rtc";
};
+
+ spi0: spi@48030000 {
+ compatible = "ti,omap4-mcspi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x48030000 0x400>;
+ interrupt-parent = <&intc>;
+ interrupt = <65>;
+ ti,spi-num-cs = <2>;
+ ti,hwmods = "spi0";
+ status = "disabled";
+ };
+
+ spi1: spi@481a0000 {
+ compatible = "ti,omap4-mcspi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x481a0000 0x400>;
+ interrupt-parent = <&intc>;
+ interrupt = <125>;
+ ti,spi-num-cs = <2>;
+ ti,hwmods = "spi1";
+ status = "disabled";
+ };
};
};
--
1.7.0.4

2012-10-31 11:44:00

by Benoit Cousson

Subject: Re: [PATCH v3] ARM: dts: AM33xx: Add SPI node

On 10/31/2012 11:51 AM, Philip, Avinash wrote:
> Add McSPI data node to AM33XX device tree file. The McSPI module (and so
> as the driver) is reused from OMAP4.
>
> Signed-off-by: Philip, Avinash <[email protected]>
> Tested-by: Matt Porter <[email protected]>
> ---

Applied in for_3.8/dts

Thanks,
Benoit

> Changes since v2:
> - Commit message corrected.
> - Rebase on top of for_3.8/dts
>
> Changes since v1:
> - Corrected reg offset in reg DT entry.
>
> :100644 100644 97a7bd3... 6e04789... M arch/arm/boot/dts/am33xx.dtsi
> arch/arm/boot/dts/am33xx.dtsi | 24 ++++++++++++++++++++++++
> 1 files changed, 24 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 97a7bd3..6e04789 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -299,5 +299,29 @@
> 76>;
> ti,hwmods = "rtc";
> };
> +
> + spi0: spi@48030000 {
> + compatible = "ti,omap4-mcspi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x48030000 0x400>;
> + interrupt-parent = <&intc>;
> + interrupt = <65>;
> + ti,spi-num-cs = <2>;
> + ti,hwmods = "spi0";
> + status = "disabled";
> + };
> +
> + spi1: spi@481a0000 {
> + compatible = "ti,omap4-mcspi";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x481a0000 0x400>;
> + interrupt-parent = <&intc>;
> + interrupt = <125>;
> + ti,spi-num-cs = <2>;
> + ti,hwmods = "spi1";
> + status = "disabled";
> + };
> };
> };
>

2012-11-01 13:50:12

by Benoit Cousson

Subject: Re: [PATCH v3] ARM: dts: AM33xx: Add SPI node

Hi Avinash,

On 10/31/2012 11:51 AM, Philip, Avinash wrote:
> Add McSPI data node to AM33XX device tree file. The McSPI module (and so
> as the driver) is reused from OMAP4.
>
> Signed-off-by: Philip, Avinash <[email protected]>
> Tested-by: Matt Porter <[email protected]>

I've just realized the interrupt-parent was still there, so I removed both.

Please find below the updated version.

Regards,
Benoit

----
>From 9fd3c748aac9418cd377249ca463050783d2198f Mon Sep 17 00:00:00 2001
From: Philip, Avinash <[email protected]>
Date: Wed, 31 Oct 2012 16:21:09 +0530
Subject: [PATCH] ARM: dts: AM33XX: Add SPI node

Add McSPI data node to AM33XX device tree file. The McSPI module (and so
as the driver) is reused from OMAP4.

Signed-off-by: Philip, Avinash <[email protected]>
Tested-by: Matt Porter <[email protected]>
[[email protected]: Remove interrupt-parent]
Signed-off-by: Benoit Cousson <[email protected]>
---
arch/arm/boot/dts/am33xx.dtsi | 22 ++++++++++++++++++++++
1 files changed, 22 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 97a7bd3..5dfd682 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -299,5 +299,27 @@
76>;
ti,hwmods = "rtc";
};
+
+ spi0: spi@48030000 {
+ compatible = "ti,omap4-mcspi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x48030000 0x400>;
+ interrupt = <65>;
+ ti,spi-num-cs = <2>;
+ ti,hwmods = "spi0";
+ status = "disabled";
+ };
+
+ spi1: spi@481a0000 {
+ compatible = "ti,omap4-mcspi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x481a0000 0x400>;
+ interrupt = <125>;
+ ti,spi-num-cs = <2>;
+ ti,hwmods = "spi1";
+ status = "disabled";
+ };
};
};
--
1.7.0.4

2012-11-05 11:34:00

by Philip, Avinash

Subject: RE: [PATCH v3] ARM: dts: AM33xx: Add SPI node

On Thu, Nov 01, 2012 at 19:19:41, Cousson, Benoit wrote:
> Hi Avinash,
>
> On 10/31/2012 11:51 AM, Philip, Avinash wrote:
> > Add McSPI data node to AM33XX device tree file. The McSPI module (and so
> > as the driver) is reused from OMAP4.
> >
> > Signed-off-by: Philip, Avinash <[email protected]>
> > Tested-by: Matt Porter <[email protected]>
>
> I've just realized the interrupt-parent was still there, so I removed both.
>
> Please find below the updated version.

I tested it and thanks for the fix.

Thanks
Avinash