2012-11-02 12:08:51

by YAMANE Toshiaki

Subject: [PATCH 1/2] Staging/media: fixed spacing coding style in go7007/wis-ov7640.c

fixed below checkpatch error.
- ERROR: that open brace { should be on the previous line

Signed-off-by: YAMANE Toshiaki <[email protected]>
---
drivers/staging/media/go7007/wis-ov7640.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/media/go7007/wis-ov7640.c b/drivers/staging/media/go7007/wis-ov7640.c
index 6bc9470..eb5efc9 100644
--- a/drivers/staging/media/go7007/wis-ov7640.c
+++ b/drivers/staging/media/go7007/wis-ov7640.c
@@ -29,8 +29,7 @@ struct wis_ov7640 {
int hue;
};

-static u8 initial_registers[] =
-{
+static u8 initial_registers[] = {
0x12, 0x80,
0x12, 0x54,
0x14, 0x24,
--
1.7.9.5

2012-11-02 12:09:37

by YAMANE Toshiaki

Subject: [PATCH 2/2] Staging/media: Use dev_ printks in go7007/wis-ov7640.c

fixed below checkpatch warnings.
- WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...

Signed-off-by: YAMANE Toshiaki <[email protected]>
---
drivers/staging/media/go7007/wis-ov7640.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/go7007/wis-ov7640.c b/drivers/staging/media/go7007/wis-ov7640.c
index eb5efc9..fe46374 100644
--- a/drivers/staging/media/go7007/wis-ov7640.c
+++ b/drivers/staging/media/go7007/wis-ov7640.c
@@ -59,12 +59,12 @@ static int wis_ov7640_probe(struct i2c_client *client,

client->flags = I2C_CLIENT_SCCB;

- printk(KERN_DEBUG
+ dev_dbg(&client->dev,
"wis-ov7640: initializing OV7640 at address %d on %s\n",
client->addr, adapter->name);

if (write_regs(client, initial_registers) < 0) {
- printk(KERN_ERR "wis-ov7640: error initializing OV7640\n");
+ dev_err(&client->dev, "wis-ov7640: error initializing OV7640\n");
return -ENODEV;
}

--
1.7.9.5

2012-11-02 12:42:41

by Peter Senna Tschudin

Subject: Re: [PATCH 1/2] Staging/media: fixed spacing coding style in go7007/wis-ov7640.c

On Fri, Nov 2, 2012 at 1:08 PM, YAMANE Toshiaki <[email protected]> wrote:
> fixed below checkpatch error.
> - ERROR: that open brace { should be on the previous line
>
> Signed-off-by: YAMANE Toshiaki <[email protected]>
Tested-by: Peter Senna Tschudin <[email protected]>
> ---
> drivers/staging/media/go7007/wis-ov7640.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/go7007/wis-ov7640.c b/drivers/staging/media/go7007/wis-ov7640.c
> index 6bc9470..eb5efc9 100644
> --- a/drivers/staging/media/go7007/wis-ov7640.c
> +++ b/drivers/staging/media/go7007/wis-ov7640.c
> @@ -29,8 +29,7 @@ struct wis_ov7640 {
> int hue;
> };
>
> -static u8 initial_registers[] =
> -{
> +static u8 initial_registers[] = {
> 0x12, 0x80,
> 0x12, 0x54,
> 0x14, 0x24,
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
Peter

2012-11-02 12:56:39

by Peter Senna Tschudin

Subject: Re: [PATCH 2/2] Staging/media: Use dev_ printks in go7007/wis-ov7640.c

On Fri, Nov 2, 2012 at 1:09 PM, YAMANE Toshiaki <[email protected]> wrote:
> fixed below checkpatch warnings.
> - WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
>
> Signed-off-by: YAMANE Toshiaki <[email protected]>
Tested-by: Peter Senna Tschudin <[email protected]>
> ---
> drivers/staging/media/go7007/wis-ov7640.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/go7007/wis-ov7640.c b/drivers/staging/media/go7007/wis-ov7640.c
> index eb5efc9..fe46374 100644
> --- a/drivers/staging/media/go7007/wis-ov7640.c
> +++ b/drivers/staging/media/go7007/wis-ov7640.c
> @@ -59,12 +59,12 @@ static int wis_ov7640_probe(struct i2c_client *client,
>
> client->flags = I2C_CLIENT_SCCB;
>
> - printk(KERN_DEBUG
> + dev_dbg(&client->dev,
> "wis-ov7640: initializing OV7640 at address %d on %s\n",
> client->addr, adapter->name);
>
> if (write_regs(client, initial_registers) < 0) {
> - printk(KERN_ERR "wis-ov7640: error initializing OV7640\n");
> + dev_err(&client->dev, "wis-ov7640: error initializing OV7640\n");
> return -ENODEV;
> }
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
Peter