2012-11-02 16:51:44

by Cesar Eduardo Barros

Subject: [PATCH] acpi: add missing newline to printk

The missing newline causes messages like this on dmesg:

[ 2.578212] ACPI: Invalid Power Resource to register!<5>[2.578456] ...

Cc: Lin Ming <[email protected]>
Cc: Len Brown <[email protected]>
Signed-off-by: Cesar Eduardo Barros <[email protected]>
---
drivers/acpi/power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
index 40e38a0..7db61b8 100644
--- a/drivers/acpi/power.c
+++ b/drivers/acpi/power.c
@@ -473,7 +473,7 @@ int acpi_power_resource_register_device(struct device *dev, acpi_handle handle)
return ret;

no_power_resource:
- printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");
+ printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!\n");
return -ENODEV;
}
EXPORT_SYMBOL_GPL(acpi_power_resource_register_device);
--
1.7.11.7

2012-11-02 20:02:25

by Rafael J. Wysocki

Subject: Re: [PATCH] acpi: add missing newline to printk

On Friday, November 02, 2012 02:51:18 PM Cesar Eduardo Barros wrote:
> The missing newline causes messages like this on dmesg:
>
> [ 2.578212] ACPI: Invalid Power Resource to register!<5>[2.578456] ...
>
> Cc: Lin Ming <[email protected]>
> Cc: Len Brown <[email protected]>
> Signed-off-by: Cesar Eduardo Barros <[email protected]>

An equivalent patch has been applied already.

Thanks,
Rafael


> ---
> drivers/acpi/power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> index 40e38a0..7db61b8 100644
> --- a/drivers/acpi/power.c
> +++ b/drivers/acpi/power.c
> @@ -473,7 +473,7 @@ int acpi_power_resource_register_device(struct device *dev, acpi_handle handle)
> return ret;
>
> no_power_resource:
> - printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");
> + printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!\n");
> return -ENODEV;
> }
> EXPORT_SYMBOL_GPL(acpi_power_resource_register_device);
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.