2012-11-07 00:58:20

by Huang, Ying

[permalink] [raw]
Subject: [PATCH -v2] ACPI/PCI: Make PCI devices notified when its power resource turned on

A set of power resources may be shared by multiple devices. When all
devices share one set of power resources is put into D3_COLD state,
the power resources will be turned off. When one of the device is
waked, the power resource will be turned on and all devices share it
will be powered on to D0uninitialized state. These devices should be
resumed, so that they can get opportunity to go to low power state
later.

v2:

- Fix build error

Signed-off-by: Huang Ying <[email protected]>
Acked-by: Rafael J. Wysocki <[email protected]>
Cc: Bjorn Helgaas <[email protected]>
---
drivers/acpi/pci_bind.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/acpi/pci_bind.c
+++ b/drivers/acpi/pci_bind.c
@@ -45,6 +45,7 @@ static int acpi_pci_unbind(struct acpi_d

device_set_run_wake(&dev->dev, false);
pci_acpi_remove_pm_notifier(device);
+ acpi_power_resource_unregister_device(&dev->dev, device->handle);

if (!dev->subordinate)
goto out;
@@ -71,6 +72,7 @@ static int acpi_pci_bind(struct acpi_dev
return 0;

pci_acpi_add_pm_notifier(device, dev);
+ acpi_power_resource_register_device(&dev->dev, device->handle);
if (device->wakeup.flags.run_wake)
device_set_run_wake(&dev->dev, true);


2012-11-13 18:59:13

by Bjorn Helgaas

[permalink] [raw]
Subject: Re: [PATCH -v2] ACPI/PCI: Make PCI devices notified when its power resource turned on

On Tue, Nov 6, 2012 at 5:57 PM, Huang Ying <[email protected]> wrote:
> A set of power resources may be shared by multiple devices. When all
> devices share one set of power resources is put into D3_COLD state,
> the power resources will be turned off. When one of the device is
> waked, the power resource will be turned on and all devices share it
> will be powered on to D0uninitialized state. These devices should be
> resumed, so that they can get opportunity to go to low power state
> later.
>
> v2:
>
> - Fix build error
>
> Signed-off-by: Huang Ying <[email protected]>
> Acked-by: Rafael J. Wysocki <[email protected]>
> Cc: Bjorn Helgaas <[email protected]>
> ---
> drivers/acpi/pci_bind.c | 2 ++
> 1 file changed, 2 insertions(+)

I applied this to my pci/misc branch as v3.8 material. Thanks!

Bjorn