2012-11-12 08:07:18

by Tushar Behera

Subject: [PATCH] [media] videobuf2-core: print current state of buffer in vb2_buffer_done

In vb2_buffer_done, it would be better the print the value of 'state'
(current state of buffer) than to print 'vb->state' which is always
VB2_BUF_STATE_ACTIVE.

Signed-off-by: Tushar Behera <[email protected]>
---
drivers/media/v4l2-core/videobuf2-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
index 432df11..91980d13 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -798,7 +798,7 @@ void vb2_buffer_done(struct vb2_buffer *vb, enum vb2_buffer_state state)
return;

dprintk(4, "Done processing on buffer %d, state: %d\n",
- vb->v4l2_buf.index, vb->state);
+ vb->v4l2_buf.index, state);

/* Add the buffer to the done buffers list */
spin_lock_irqsave(&q->done_lock, flags);
--
1.7.4.1

2013-03-25 10:59:45

by Marek Szyprowski

Subject: Re: [PATCH] [media] videobuf2-core: print current state of buffer in vb2_buffer_done

Hello,

Tushar Behera <tushar.behera <at> linaro.org> writes:

> In vb2_buffer_done, it would be better the print the value of 'state'
> (current state of buffer) than to print 'vb->state' which is always
> VB2_BUF_STATE_ACTIVE.
>
> Signed-off-by: Tushar Behera <tushar.behera <at> linaro.org>

Acked-by: Marek Szyprowski <[email protected]>

> ---
> drivers/media/v4l2-core/videobuf2-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)