2012-11-22 18:26:54

by Sachin Kamat

[permalink] [raw]
Subject: [PATCH Resend] tty: vt: Remove redundant null check before kfree.

kfree on a NULL pointer is a no-op.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/tty/vt/consolemap.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/vt/consolemap.c b/drivers/tty/vt/consolemap.c
index 2aaa0c2..248381b 100644
--- a/drivers/tty/vt/consolemap.c
+++ b/drivers/tty/vt/consolemap.c
@@ -410,10 +410,8 @@ static void con_release_unimap(struct uni_pagedir *p)
kfree(p->inverse_translations[i]);
p->inverse_translations[i] = NULL;
}
- if (p->inverse_trans_unicode) {
- kfree(p->inverse_trans_unicode);
- p->inverse_trans_unicode = NULL;
- }
+ kfree(p->inverse_trans_unicode);
+ p->inverse_trans_unicode = NULL;
}

/* Caller must hold the console lock */
--
1.7.4.1