2012-11-27 00:21:09

by Linus Walleij

Subject: [PATCH] irqdomain: stop screaming about preallocated irqdescs

From: Linus Walleij <[email protected]>

In the simple irqdomain: don't shout warnings to the user,
there is no point. An informational print is sufficient.

Cc: Rob Herring <[email protected]>
Cc: Grant Likely <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>
---
kernel/irq/irqdomain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 4e69e24..96f3a1d 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -177,8 +177,8 @@ struct irq_domain *irq_domain_add_simple(struct device_node *of_node,
irq_base = irq_alloc_descs(first_irq, first_irq, size,
of_node_to_nid(of_node));
if (irq_base < 0) {
- WARN(1, "Cannot allocate irq_descs @ IRQ%d, assuming pre-allocated\n",
- first_irq);
+ pr_info("Cannot allocate irq_descs @ IRQ%d, assuming pre-allocated\n",
+ first_irq);
irq_base = first_irq;
}
} else
--
1.7.11.3

2012-11-30 09:02:53

by Grant Likely

Subject: Re: [PATCH] irqdomain: stop screaming about preallocated irqdescs

On Tue, 27 Nov 2012 01:20:32 +0100, Linus Walleij <[email protected]> wrote:
> From: Linus Walleij <[email protected]>
>
> In the simple irqdomain: don't shout warnings to the user,
> there is no point. An informational print is sufficient.
>
> Cc: Rob Herring <[email protected]>
> Cc: Grant Likely <[email protected]>
> Cc: Thomas Gleixner <[email protected]>
> Signed-off-by: Linus Walleij <[email protected]>

Applied, thanks.

g.

> ---
> kernel/irq/irqdomain.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 4e69e24..96f3a1d 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -177,8 +177,8 @@ struct irq_domain *irq_domain_add_simple(struct device_node *of_node,
> irq_base = irq_alloc_descs(first_irq, first_irq, size,
> of_node_to_nid(of_node));
> if (irq_base < 0) {
> - WARN(1, "Cannot allocate irq_descs @ IRQ%d, assuming pre-allocated\n",
> - first_irq);
> + pr_info("Cannot allocate irq_descs @ IRQ%d, assuming pre-allocated\n",
> + first_irq);
> irq_base = first_irq;
> }
> } else
> --
> 1.7.11.3
>

--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.