2012-11-28 10:01:14

by Oskar Schirmer

[permalink] [raw]
Subject: [PATCH] sound/sgtl5000: fix initial setting for DAC data source

According to documentation bit 3:2 in register SSS_CTRL are
reserved and zero, so the setting of 0x0008 does not make much sense.
Instead, bit 4 should be set as is with power up, to reflect
routing of I2S_IN to DAC correctly.

Looks much like an off by one error.

Signed-off-by: Oskar Schirmer <[email protected]>
---
sound/soc/codecs/sgtl5000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index df2f99d..5b37891 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -37,7 +37,7 @@
static const u16 sgtl5000_regs[SGTL5000_MAX_REG_OFFSET] = {
[SGTL5000_CHIP_CLK_CTRL] = 0x0008,
[SGTL5000_CHIP_I2S_CTRL] = 0x0010,
- [SGTL5000_CHIP_SSS_CTRL] = 0x0008,
+ [SGTL5000_CHIP_SSS_CTRL] = 0x0010,
[SGTL5000_CHIP_DAC_VOL] = 0x3c3c,
[SGTL5000_CHIP_PAD_STRENGTH] = 0x015f,
[SGTL5000_CHIP_ANA_HP_CTRL] = 0x1818,
--
1.7.9.5


2012-11-28 09:58:41

by Liam Girdwood

[permalink] [raw]
Subject: Re: [PATCH] sound/sgtl5000: fix initial setting for DAC data source

On 28/11/12 09:20, Oskar Schirmer wrote:
> According to documentation bit 3:2 in register SSS_CTRL are
> reserved and zero, so the setting of 0x0008 does not make much sense.
> Instead, bit 4 should be set as is with power up, to reflect
> routing of I2S_IN to DAC correctly.
>
> Looks much like an off by one error.

Could you resend this to alsa-devel and CC maintainers.

Thanks

Liam

2012-11-28 10:14:34

by Oskar Schirmer

[permalink] [raw]
Subject: [PATCH] sound/sgtl5000: fix initial setting for DAC data source

According to documentation bit 3:2 in register SSS_CTRL are
reserved and zero, so the setting of 0x0008 does not make much sense.
Instead, bit 4 should be set as is with power up, to reflect
routing of I2S_IN to DAC correctly.

Looks much like an off by one error.

Signed-off-by: Oskar Schirmer <[email protected]>
---
sound/soc/codecs/sgtl5000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index df2f99d..5b37891 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -37,7 +37,7 @@
static const u16 sgtl5000_regs[SGTL5000_MAX_REG_OFFSET] = {
[SGTL5000_CHIP_CLK_CTRL] = 0x0008,
[SGTL5000_CHIP_I2S_CTRL] = 0x0010,
- [SGTL5000_CHIP_SSS_CTRL] = 0x0008,
+ [SGTL5000_CHIP_SSS_CTRL] = 0x0010,
[SGTL5000_CHIP_DAC_VOL] = 0x3c3c,
[SGTL5000_CHIP_PAD_STRENGTH] = 0x015f,
[SGTL5000_CHIP_ANA_HP_CTRL] = 0x1818,
--
1.7.9.5

2012-11-28 14:00:01

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] sound/sgtl5000: fix initial setting for DAC data source

On Wed, Nov 28, 2012 at 10:14:28AM +0000, Oskar Schirmer wrote:

You've somehow decided to CC half the world but still haven't managed
to CC the maintainers like Liam asked (and as is covered in
SubmittingPatches)...

> According to documentation bit 3:2 in register SSS_CTRL are
> reserved and zero, so the setting of 0x0008 does not make much sense.
> Instead, bit 4 should be set as is with power up, to reflect
> routing of I2S_IN to DAC correctly.

> Looks much like an off by one error.

What does "as is with power up" mean? This is a register defaults
table, it should reflect what is in the register defaults. The meaning
of the field and the desired configuration for runtime is not relevant
here, the only thing that matters is what the default value of the
register is.