2012-11-28 18:47:32

by Mark Brown

[permalink] [raw]
Subject: [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2

Signed-off-by: Mark Brown <[email protected]>
---
drivers/mfd/wm5102-tables.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c
index 50bbe15..065ffd3 100644
--- a/drivers/mfd/wm5102-tables.c
+++ b/drivers/mfd/wm5102-tables.c
@@ -307,6 +307,7 @@ static const struct reg_default wm5102_reg_default[] = {
{ 0x000001AA, 0x0004 }, /* R426 - FLL2 GPIO Clock */
{ 0x00000200, 0x0006 }, /* R512 - Mic Charge Pump 1 */
{ 0x00000210, 0x00D4 }, /* R528 - LDO1 Control 1 */
+ { 0x00000212, 0x0001 }, /* R530 - LDO1 Control 2 */
{ 0x00000213, 0x0344 }, /* R531 - LDO2 Control 1 */
{ 0x00000218, 0x01A6 }, /* R536 - Mic Bias Ctrl 1 */
{ 0x00000219, 0x01A6 }, /* R537 - Mic Bias Ctrl 2 */
--
1.7.10.4


2012-11-29 11:18:30

by Charles Keepax

[permalink] [raw]
Subject: Re: [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2

On Wed, Nov 28, 2012 at 06:47:28PM +0000, Mark Brown wrote:
> Signed-off-by: Mark Brown <[email protected]>
> ---
> drivers/mfd/wm5102-tables.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c
> index 50bbe15..065ffd3 100644
> --- a/drivers/mfd/wm5102-tables.c
> +++ b/drivers/mfd/wm5102-tables.c
> @@ -307,6 +307,7 @@ static const struct reg_default wm5102_reg_default[] = {
> { 0x000001AA, 0x0004 }, /* R426 - FLL2 GPIO Clock */
> { 0x00000200, 0x0006 }, /* R512 - Mic Charge Pump 1 */
> { 0x00000210, 0x00D4 }, /* R528 - LDO1 Control 1 */
> + { 0x00000212, 0x0001 }, /* R530 - LDO1 Control 2 */

The default for this register is changed in the register patch to
zero should we not leave this setting at zero to match?

2012-11-29 11:40:35

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2

On Thu, Nov 29, 2012 at 11:18:27AM +0000, Charles Keepax wrote:
> On Wed, Nov 28, 2012 at 06:47:28PM +0000, Mark Brown wrote:

> > + { 0x00000212, 0x0001 }, /* R530 - LDO1 Control 2 */

> The default for this register is changed in the register patch to
> zero should we not leave this setting at zero to match?

The patch file is different for newer revs, I suspect we will be
changing the patch for rev A to follow suit.

Attachments:
(No filename) (428.00 B)
 signature.asc (836.00 B)
Digital signature Download all attachments

2012-11-30 10:20:30

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH] mfd: wm5102: Correct default for LDO1_CONTROL_2

Hi Mark,

On Wed, Nov 28, 2012 at 06:47:28PM +0000, Mark Brown wrote:
> Signed-off-by: Mark Brown <[email protected]>
> ---
> drivers/mfd/wm5102-tables.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/