2012-11-29 06:36:12

by Abhijit Pawar

Subject: [PATCH 6/6] fs:sysfs pass NULL as second parameter for set_anon_super

set_anon_super does not use the second parameter in its implementation.
So there is no need to pass on the second parameter.

Signed-off-by: Abhijit Pawar <[email protected]>
---
fs/sysfs/mount.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c
index db940a9..3e3f7ea 100644
--- a/fs/sysfs/mount.c
+++ b/fs/sysfs/mount.c
@@ -89,7 +89,7 @@ static int sysfs_test_super(struct super_block *sb, void *data)
static int sysfs_set_super(struct super_block *sb, void *data)
{
int error;
- error = set_anon_super(sb, data);
+ error = set_anon_super(sb, NULL);
if (!error)
sb->s_fs_info = data;
return error;
--
1.7.7.6

2012-11-29 15:35:06

by Greg Kroah-Hartman

Subject: Re: [PATCH 6/6] fs:sysfs pass NULL as second parameter for set_anon_super

On Thu, Nov 29, 2012 at 12:05:45PM +0530, Abhijit Pawar wrote:
> set_anon_super does not use the second parameter in its implementation.
> So there is no need to pass on the second parameter.

Why not just remove the second parameter from the call then?

thanks,

greg k-h

2012-11-30 05:32:31

by Abhijit Pawar

Subject: Re: [PATCH 6/6] fs:sysfs pass NULL as second parameter for set_anon_super

On 11/29/2012 09:06 PM, Greg Kroah-Hartman wrote:
> On Thu, Nov 29, 2012 at 12:05:45PM +0530, Abhijit Pawar wrote:
>> set_anon_super does not use the second parameter in its implementation.
>> So there is no need to pass on the second parameter.
>
> Why not just remove the second parameter from the call then?
>
> thanks,
>
> greg k-h
>

This is used as a callback function. So changing the signature will
affect many other filesystems who use the default function rather than
the overridden one.


--
-
Abhijit