2013-03-01 11:15:37

by Ashish Jangam

Subject: Re: [patch v1 1/5] mfd: da9055 change irq state to default

On Fri, 2013-01-18 at 10:49 +0530, Ashish Jangam wrote:
> This patch changes the irq state from high to the now default low
> state.
>
> This patch is tested on smdk6410 board.
>
> Signed-off-by: Ashish Jangam <[email protected]>
> ---
> drivers/mfd/da9055-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c
> index f56a1a9..49cb23d 100644
> --- a/drivers/mfd/da9055-core.c
> +++ b/drivers/mfd/da9055-core.c
> @@ -391,7 +391,7 @@ int da9055_device_init(struct da9055 *da9055)
> da9055->irq_base = pdata->irq_base;
>
> ret = regmap_add_irq_chip(da9055->regmap, da9055->chip_irq,
> - IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> + IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> da9055->irq_base, &da9055_regmap_irq_chip,
> &da9055->irq_data);
> if (ret < 0)
Can you let me know if this patch looks good to get merged?

2013-03-08 14:26:44

by Ashish Jangam

Subject: Re: [patch v1 1/5] mfd: da9055 change irq state to default

On Fri, 2013-03-01 at 16:43 +0530, Ashish Jangam wrote:
> On Fri, 2013-01-18 at 10:49 +0530, Ashish Jangam wrote:
> > This patch changes the irq state from high to the now default low
> > state.
> >
> > This patch is tested on smdk6410 board.
> >
> > Signed-off-by: Ashish Jangam <[email protected]>
> > ---
> > drivers/mfd/da9055-core.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mfd/da9055-core.c b/drivers/mfd/da9055-core.c
> > index f56a1a9..49cb23d 100644
> > --- a/drivers/mfd/da9055-core.c
> > +++ b/drivers/mfd/da9055-core.c
> > @@ -391,7 +391,7 @@ int da9055_device_init(struct da9055 *da9055)
> > da9055->irq_base = pdata->irq_base;
> >
> > ret = regmap_add_irq_chip(da9055->regmap, da9055->chip_irq,
> > - IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> > + IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> > da9055->irq_base, &da9055_regmap_irq_chip,
> > &da9055->irq_data);
> > if (ret < 0)
> Can you let me know if this patch looks good to get merged?
Any update? Sorry to ping, just need to close this small change till
earlier.