2013-03-02 07:26:41

by Mark Brown

Subject: [PATCH] mfd: tps65912: Declare and use tps65912_irq_exit()

Clean up interrupts on exit, silencing a sparse warning caused by
tps65912_irq_exit() being defined but not prototyped as we go.

Signed-off-by: Mark Brown <[email protected]>
---
drivers/mfd/tps65912-core.c | 1 +
include/linux/mfd/tps65912.h | 1 +
2 files changed, 2 insertions(+)

diff --git a/drivers/mfd/tps65912-core.c b/drivers/mfd/tps65912-core.c
index 4658b5b..aeb8e40 100644
--- a/drivers/mfd/tps65912-core.c
+++ b/drivers/mfd/tps65912-core.c
@@ -169,6 +169,7 @@ err:
void tps65912_device_exit(struct tps65912 *tps65912)
{
mfd_remove_devices(tps65912->dev);
+ tps65912_irq_exit(tps65912);
kfree(tps65912);
}

diff --git a/include/linux/mfd/tps65912.h b/include/linux/mfd/tps65912.h
index aaceab4..6d30903 100644
--- a/include/linux/mfd/tps65912.h
+++ b/include/linux/mfd/tps65912.h
@@ -323,5 +323,6 @@ int tps65912_device_init(struct tps65912 *tps65912);
void tps65912_device_exit(struct tps65912 *tps65912);
int tps65912_irq_init(struct tps65912 *tps65912, int irq,
struct tps65912_platform_data *pdata);
+int tps65912_irq_exit(struct tps65912 *tps65912);

#endif /* __LINUX_MFD_TPS65912_H */
--
1.7.10.4

2013-03-13 08:38:23

by Samuel Ortiz

Subject: Re: [PATCH] mfd: tps65912: Declare and use tps65912_irq_exit()

Hi Mark,

On Sat, Mar 02, 2013 at 03:25:50PM +0800, Mark Brown wrote:
> Clean up interrupts on exit, silencing a sparse warning caused by
> tps65912_irq_exit() being defined but not prototyped as we go.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> drivers/mfd/tps65912-core.c | 1 +
> include/linux/mfd/tps65912.h | 1 +
> 2 files changed, 2 insertions(+)
Applied to my mfd-fixes tree, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/