2013-03-02 20:48:15

by Silviu-Mihai Popescu

Subject: [PATCH] caif_dev: fix sparse warnings for caif_flow_cb

This fixed the following sparse warning:
net/caif/caif_dev.c:121:6: warning: symbol 'caif_flow_cb' was not
declared. Should it be static?

Signed-off-by: Silviu-Mihai Popescu <[email protected]>
---
net/caif/caif_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c
index 1ae1d9c..21760f0 100644
--- a/net/caif/caif_dev.c
+++ b/net/caif/caif_dev.c
@@ -118,7 +118,7 @@ static struct caif_device_entry *caif_get(struct net_device *dev)
return NULL;
}

-void caif_flow_cb(struct sk_buff *skb)
+static void caif_flow_cb(struct sk_buff *skb)
{
struct caif_device_entry *caifd;
void (*dtor)(struct sk_buff *skb) = NULL;
--
1.7.9.5

2013-03-03 06:44:24

by David Miller

Subject: Re: [PATCH] caif_dev: fix sparse warnings for caif_flow_cb

From: Silviu-Mihai Popescu <[email protected]>
Date: Sat, 2 Mar 2013 21:45:19 +0200

> This fixed the following sparse warning:
> net/caif/caif_dev.c:121:6: warning: symbol 'caif_flow_cb' was not
> declared. Should it be static?
>
> Signed-off-by: Silviu-Mihai Popescu <[email protected]>

Applied.