Subject: [PATCH] scripts/mod: add device table offsets file to list of files to clean

From: Fernando Luis Vázquez Cao <[email protected]>

This file is generated so it does not get cleaned automagically. In other words
we need to added to the clean-files list.

Signed-off-by: Fernando Luis Vázquez Cao <[email protected]>
---

diff -urNp linux-3.9-rc1-orig/scripts/mod/Makefile linux-3.9-rc1/scripts/mod/Makefile
--- linux-3.9-rc1-orig/scripts/mod/Makefile 2013-03-04 16:09:29.297904000 +0900
+++ linux-3.9-rc1/scripts/mod/Makefile 2013-03-04 18:06:16.359389000 +0900
@@ -49,3 +49,5 @@ $(obj)/elfconfig.h: $(obj)/empty.o $(obj
$(call if_changed,elfconfig)

targets += elfconfig.h
+
+clean-files := $(devicetable-offsets-file)


Subject: Re: [PATCH] scripts/mod: add device table offsets file to list of files to clean

Hi Michal,

On 2013/03/04 18:57, Fernando Luis Vázquez Cao wrote:
> From: Fernando Luis Vázquez Cao <[email protected]>
>
> This file is generated so it does not get cleaned automagically. In other words
> we need to added to the clean-files list.
>
> Signed-off-by: Fernando Luis Vázquez Cao <[email protected]>
> ---
>
> diff -urNp linux-3.9-rc1-orig/scripts/mod/Makefile linux-3.9-rc1/scripts/mod/Makefile
> --- linux-3.9-rc1-orig/scripts/mod/Makefile 2013-03-04 16:09:29.297904000 +0900
> +++ linux-3.9-rc1/scripts/mod/Makefile 2013-03-04 18:06:16.359389000 +0900
> @@ -49,3 +49,5 @@ $(obj)/elfconfig.h: $(obj)/empty.o $(obj
> $(call if_changed,elfconfig)
>
> targets += elfconfig.h
> +
> +clean-files := $(devicetable-offsets-file)

Do you see any problem with this patch?

Thanks,
Fernando

2013-04-08 14:34:14

by Michal Marek

[permalink] [raw]
Subject: Re: [PATCH] scripts/mod: add device table offsets file to list of files to clean

On 19.3.2013 08:00, Fernando Luis Vazquez Cao wrote:
> Hi Michal,
>
> On 2013/03/04 18:57, Fernando Luis Vázquez Cao wrote:
>> From: Fernando Luis Vázquez Cao <[email protected]>
>>
>> This file is generated so it does not get cleaned automagically. In
>> other words
>> we need to added to the clean-files list.
>>
>> Signed-off-by: Fernando Luis Vázquez Cao <[email protected]>
>> ---
>>
>> diff -urNp linux-3.9-rc1-orig/scripts/mod/Makefile
>> linux-3.9-rc1/scripts/mod/Makefile
>> --- linux-3.9-rc1-orig/scripts/mod/Makefile 2013-03-04
>> 16:09:29.297904000 +0900
>> +++ linux-3.9-rc1/scripts/mod/Makefile 2013-03-04
>> 18:06:16.359389000 +0900
>> @@ -49,3 +49,5 @@ $(obj)/elfconfig.h: $(obj)/empty.o $(obj
>> $(call if_changed,elfconfig)
>> targets += elfconfig.h
>> +
>> +clean-files := $(devicetable-offsets-file)
>
> Do you see any problem with this patch?

Yes, it does not work, at least not on top of 3.9-rc1. You need to add
'scripts' to the $(clean-dirs) list in the main Makefile, so that make
clean descends into scripts/mod.

Michal