2013-03-07 10:46:10

by Samuel Tardieu

Subject: [PATCH] USB: cdc-acm: Remove obsolete predefined speeds array

Modern speed handling has been introduced by commit
9b80fee149a875a6292b2556ab2c64dc7ab7d6f5 in 2009 and the
acm_tty_speed array has been unused since.

Signed-off-by: Samuel Tardieu <[email protected]>
---
drivers/usb/class/cdc-acm.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 8ac25ad..d003c8c 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -840,14 +840,6 @@ static int acm_tty_ioctl(struct tty_struct *tty,
return rv;
}

-static const __u32 acm_tty_speed[] = {
- 0, 50, 75, 110, 134, 150, 200, 300, 600,
- 1200, 1800, 2400, 4800, 9600, 19200, 38400,
- 57600, 115200, 230400, 460800, 500000, 576000,
- 921600, 1000000, 1152000, 1500000, 2000000,
- 2500000, 3000000, 3500000, 4000000
-};
-
static void acm_tty_set_termios(struct tty_struct *tty,
struct ktermios *termios_old)
{
--
1.8.1.5

2013-03-07 11:35:55

by Oliver Neukum

Subject: Re: [PATCH] USB: cdc-acm: Remove obsolete predefined speeds array

On Thursday 07 March 2013 11:39:28 Samuel Tardieu wrote:
> Modern speed handling has been introduced by commit
> 9b80fee149a875a6292b2556ab2c64dc7ab7d6f5 in 2009 and the
> acm_tty_speed array has been unused since.
>
> Signed-off-by: Samuel Tardieu <[email protected]>
Acked-by: Oliver Neukum <[email protected]>