2013-03-11 11:17:10

by Mihnea Dobrescu-Balaur

Subject: [PATCH] aoe: replace kmalloc and then memcpy with kmemdup

Signed-off-by: Mihnea Dobrescu-Balaur <[email protected]>
---
drivers/block/aoe/aoechr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/block/aoe/aoechr.c b/drivers/block/aoe/aoechr.c
index 42e67ad..ab41be6 100644
--- a/drivers/block/aoe/aoechr.c
+++ b/drivers/block/aoe/aoechr.c
@@ -139,13 +139,12 @@ bail: spin_unlock_irqrestore(&emsgs_lock, flags);
return;
}

- mp = kmalloc(n, GFP_ATOMIC);
+ mp = kmemdup(msg, n, GFP_ATOMIC);
if (mp == NULL) {
printk(KERN_ERR "aoe: allocation failure, len=%ld\n", n);
goto bail;
}

- memcpy(mp, msg, n);
em->msg = mp;
em->flags |= EMFL_VALID;
em->len = n;
--
1.7.10.4

2013-03-11 17:45:06

by Ed L. Cashin

Subject: Re: [PATCH] aoe: replace kmalloc and then memcpy with kmemdup

Looks OK, thanks.

On Mar 11, 2013, at 7:16 AM, Mihnea Dobrescu-Balaur wrote:

> Signed-off-by: Mihnea Dobrescu-Balaur <[email protected]>
> ---
> drivers/block/aoe/aoechr.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/aoe/aoechr.c b/drivers/block/aoe/aoechr.c
> index 42e67ad..ab41be6 100644
> --- a/drivers/block/aoe/aoechr.c
> +++ b/drivers/block/aoe/aoechr.c
> @@ -139,13 +139,12 @@ bail: spin_unlock_irqrestore(&emsgs_lock, flags);
> return;
> }
>
> - mp = kmalloc(n, GFP_ATOMIC);
> + mp = kmemdup(msg, n, GFP_ATOMIC);
> if (mp == NULL) {
> printk(KERN_ERR "aoe: allocation failure, len=%ld\n", n);
> goto bail;
> }
>
> - memcpy(mp, msg, n);
> em->msg = mp;
> em->flags |= EMFL_VALID;
> em->len = n;
> --
> 1.7.10.4
>

--
Ed Cashin
[email protected]