2013-03-11 19:23:12

by Valentin Ilie

Subject: [PATCH] Arch: x86: kernel: smpboot.c: Remove unused variable

Remove unused variable 'c'

Signed-off-by: Valentin Ilie <[email protected]>
---
arch/x86/kernel/smpboot.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index a6ceaed..7bc998a 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1367,7 +1367,6 @@ static inline void mwait_play_dead(void)
unsigned int highest_subcstate = 0;
int i;
void *mwait_ptr;
- struct cpuinfo_x86 *c = __this_cpu_ptr(&cpu_info);

if (!this_cpu_has(X86_FEATURE_MWAIT))
return;
--
1.7.10.4

2013-03-11 19:57:24

by Daniel Baluta

Subject: Re: [PATCH] Arch: x86: kernel: smpboot.c: Remove unused variable

On Mon, Mar 11, 2013 at 9:23 PM, Valentin Ilie <[email protected]> wrote:
> Remove unused variable 'c'
>
> Signed-off-by: Valentin Ilie <[email protected]>
> ---
> arch/x86/kernel/smpboot.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index a6ceaed..7bc998a 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -1367,7 +1367,6 @@ static inline void mwait_play_dead(void)
> unsigned int highest_subcstate = 0;
> int i;
> void *mwait_ptr;
> - struct cpuinfo_x86 *c = __this_cpu_ptr(&cpu_info);
>
> if (!this_cpu_has(X86_FEATURE_MWAIT))
> return;
> --
> 1.7.10.4

Hi Valentin,

I guess a better subject for this patch should be
x86, smpboot: Remove unused variable

Use git log arch/x86/kernel/smpboot.c to check previous commits.

thanks,
Daniel.

2013-03-11 20:02:33

by H. Peter Anvin

Subject: Re: [PATCH] Arch: x86: kernel: smpboot.c: Remove unused variable

On 03/11/2013 12:23 PM, Valentin Ilie wrote:
> Remove unused variable 'c'
>
> Signed-off-by: Valentin Ilie <[email protected]>
> ---
> arch/x86/kernel/smpboot.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index a6ceaed..7bc998a 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -1367,7 +1367,6 @@ static inline void mwait_play_dead(void)
> unsigned int highest_subcstate = 0;
> int i;
> void *mwait_ptr;
> - struct cpuinfo_x86 *c = __this_cpu_ptr(&cpu_info);
>
> if (!this_cpu_has(X86_FEATURE_MWAIT))
> return;
>

Already done.

-hpa