2013-03-12 18:33:17

by Alexandru Gheorghiu

Subject: [PATCH] drivers: acpi: Used PTR_RET function

Used PTR_RET function instead of explicit checking with IS_ERR.

Signed-off-by: Alexandru Gheorghiu <[email protected]>
---
drivers/acpi/acpi_pad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c
index 31de104..27bb6a9 100644
--- a/drivers/acpi/acpi_pad.c
+++ b/drivers/acpi/acpi_pad.c
@@ -236,7 +236,7 @@ static int create_power_saving_task(void)
ps_tsks[ps_tsk_num] = kthread_run(power_saving_thread,
(void *)(unsigned long)ps_tsk_num,
"acpi_pad/%d", ps_tsk_num);
- rc = IS_ERR(ps_tsks[ps_tsk_num]) ? PTR_ERR(ps_tsks[ps_tsk_num]) : 0;
+ rc = PTR_RET(ps_tsks[ps_tsk_num]);
if (!rc)
ps_tsk_num++;
else
--
1.7.9.5

2013-03-26 13:21:09

by Rafael J. Wysocki

Subject: Re: [PATCH] drivers: acpi: Used PTR_RET function

On Tuesday, March 12, 2013 10:32:51 AM Alexandru Gheorghiu wrote:
> Used PTR_RET function instead of explicit checking with IS_ERR.
>
> Signed-off-by: Alexandru Gheorghiu <[email protected]>

Applied to linux-pm.git/linux-next.

Thanks,
Rafael


> ---
> drivers/acpi/acpi_pad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c
> index 31de104..27bb6a9 100644
> --- a/drivers/acpi/acpi_pad.c
> +++ b/drivers/acpi/acpi_pad.c
> @@ -236,7 +236,7 @@ static int create_power_saving_task(void)
> ps_tsks[ps_tsk_num] = kthread_run(power_saving_thread,
> (void *)(unsigned long)ps_tsk_num,
> "acpi_pad/%d", ps_tsk_num);
> - rc = IS_ERR(ps_tsks[ps_tsk_num]) ? PTR_ERR(ps_tsks[ps_tsk_num]) : 0;
> + rc = PTR_RET(ps_tsks[ps_tsk_num]);
> if (!rc)
> ps_tsk_num++;
> else
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.