2013-03-13 19:46:50

by Alexandru Gheorghiu

Subject: [PATCH] arch: s390: mm: Removed useless label

Rewrote conditional statement and eliminated the out_kthread label.

Signed-off-by: Alexandru Gheorghiu <[email protected]>
---
arch/s390/mm/cmm.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/s390/mm/cmm.c b/arch/s390/mm/cmm.c
index 479e942..9d84a1f 100644
--- a/arch/s390/mm/cmm.c
+++ b/arch/s390/mm/cmm.c
@@ -458,12 +458,10 @@ static int __init cmm_init(void)
if (rc)
goto out_pm;
cmm_thread_ptr = kthread_run(cmm_thread, NULL, "cmmthread");
- rc = IS_ERR(cmm_thread_ptr) ? PTR_ERR(cmm_thread_ptr) : 0;
- if (rc)
- goto out_kthread;
- return 0;
+ if (!IS_ERR(cmm_thread_ptr))
+ return 0;

-out_kthread:
+ rc = PTR_ERR(cmm_thread_ptr);
unregister_pm_notifier(&cmm_power_notifier);
out_pm:
unregister_oom_notifier(&cmm_oom_nb);
--
1.7.9.5

2013-03-14 07:24:03

by Heiko Carstens

Subject: Re: [PATCH] arch: s390: mm: Removed useless label

On Wed, Mar 13, 2013 at 09:46:08PM +0200, Alexandru Gheorghiu wrote:
> Rewrote conditional statement and eliminated the out_kthread label.
>
> Signed-off-by: Alexandru Gheorghiu <[email protected]>
> ---
> arch/s390/mm/cmm.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)

Applied, thanks.