2013-03-15 18:23:18

by Alexandru Gheorghiu

Subject: [PATCH] net: dns_resolver: Use kmemdup instead of kmalloc and memcpy

Replace use of kmalloc followed by memcpy with kmemdup.
Patch found using coccinelle.

Signed-off-by: Alexandru Gheorghiu <[email protected]>
---
net/dns_resolver/dns_query.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/dns_resolver/dns_query.c b/net/dns_resolver/dns_query.c
index c32be29..4ac62fb 100644
--- a/net/dns_resolver/dns_query.c
+++ b/net/dns_resolver/dns_query.c
@@ -146,11 +146,10 @@ int dns_query(const char *type, const char *name, size_t namelen,
len = upayload->datalen;

ret = -ENOMEM;
- *_result = kmalloc(len + 1, GFP_KERNEL);
+ *_result = kmemdup(upayload->data, len + 1, GFP_KERNEL);
if (!*_result)
goto put;

- memcpy(*_result, upayload->data, len + 1);
if (_expiry)
*_expiry = rkey->expiry;

--
1.7.9.5