2013-03-17 09:12:08

by Alexandru Gheorghiu

Subject: [PATCH] drivers: cpuidle: Use devm_ioremap_resource function

Use devm_ioremap_resource function, which provides better error handling,
instead of devm_request_and_ioremap.
Patch found using coccinelle.

Signed-off-by: Alexandru Gheorghiu <[email protected]>
---
drivers/cpuidle/cpuidle-kirkwood.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
index 670aa1e..53aad73 100644
--- a/drivers/cpuidle/cpuidle-kirkwood.c
+++ b/drivers/cpuidle/cpuidle-kirkwood.c
@@ -66,9 +66,9 @@ static int kirkwood_cpuidle_probe(struct platform_device *pdev)
if (res == NULL)
return -EINVAL;

- ddr_operation_base = devm_request_and_ioremap(&pdev->dev, res);
- if (!ddr_operation_base)
- return -EADDRNOTAVAIL;
+ ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(ddr_operation_base))
+ return PTR_ERR(ddr_operation_base);

device = &per_cpu(kirkwood_cpuidle_device, smp_processor_id());
device->state_count = KIRKWOOD_MAX_STATES;
--
1.7.9.5

2013-03-18 13:26:16

by Jason Cooper

Subject: Re: [PATCH] drivers: cpuidle: Use devm_ioremap_resource function

On Sat, Mar 16, 2013 at 04:39:21PM +0200, Alexandru Gheorghiu wrote:
> Use devm_ioremap_resource function, which provides better error handling,
> instead of devm_request_and_ioremap.
> Patch found using coccinelle.
>
> Signed-off-by: Alexandru Gheorghiu <[email protected]>
> ---
> drivers/cpuidle/cpuidle-kirkwood.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Acked-by: Jason Cooper <[email protected]>

thx,

Jason.