2013-03-17 06:18:49

by Silviu-Mihai Popescu

Subject: [PATCH] power: 88pm860x: fix invalid free of devm_* allocated data

The objects allocated by devm_* APIs are managed by devres and are freed
when the device is detached. There is no need to use kfree() explicitly.

Signed-off-by: Silviu-Mihai Popescu <[email protected]>
---
drivers/power/88pm860x_charger.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/power/88pm860x_charger.c b/drivers/power/88pm860x_charger.c
index 4b37a5a..d7ceeac 100644
--- a/drivers/power/88pm860x_charger.c
+++ b/drivers/power/88pm860x_charger.c
@@ -714,7 +714,6 @@ out_irq:
while (--i >= 0)
free_irq(info->irq[i], info);
out:
- kfree(info);
return ret;
}

--
1.7.9.5

2013-04-01 06:40:57

by Anton Vorontsov

Subject: Re: [PATCH] power: 88pm860x: fix invalid free of devm_* allocated data

On Sun, Mar 17, 2013 at 08:18:43AM +0200, Silviu-Mihai Popescu wrote:
> The objects allocated by devm_* APIs are managed by devres and are freed
> when the device is detached. There is no need to use kfree() explicitly.
>
> Signed-off-by: Silviu-Mihai Popescu <[email protected]>
> ---

Jingoo Han sent a similar patch earlier...

Anyway, thanks!

Anton