2013-03-18 03:12:55

by Wei Yongjun

Subject: [PATCH -next] UBIFS: fix missing unlock on error in ubifs_remount_rw()

From: Wei Yongjun <[email protected]>

Add the missing unlock before return from function ubifs_remount_rw()
in the error handling case.

Signed-off-by: Wei Yongjun <[email protected]>
---
fs/ubifs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index f21acf0..9791b3c 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -1571,7 +1571,7 @@ static int ubifs_remount_rw(struct ubifs_info *c)
if (c->space_fixup) {
err = ubifs_fixup_free_space(c);
if (err)
- return err;
+ goto out;
}

err = check_free_space(c);

2013-03-19 14:06:49

by Artem Bityutskiy

Subject: Re: [PATCH -next] UBIFS: fix missing unlock on error in ubifs_remount_rw()

On Mon, 2013-03-18 at 11:12 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Add the missing unlock before return from function ubifs_remount_rw()
> in the error handling case.
>
> Signed-off-by: Wei Yongjun <[email protected]>

Thanks, I fixed this up in linux-ubifs.git.

--
Best Regards,
Artem Bityutskiy