2013-03-21 07:11:54

by Ashish Jangam

Subject: [patch v1]rtc: fix for DA9052/53 rtc device registration

This patch adds supports for the virtual irq since now MFD only handles virtual irq
Without this patch rtc device will fail in registration.

This patch is for Linux stable version 3.8.x

Signed-off-by: Ashish Jangam <[email protected]>
---
drivers/rtc/rtc-da9052.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/rtc/rtc-da9052.c b/drivers/rtc/rtc-da9052.c
index 60b826e..e22c950 100644
--- a/drivers/rtc/rtc-da9052.c
+++ b/drivers/rtc/rtc-da9052.c
@@ -239,10 +239,10 @@ static int da9052_rtc_probe(struct platform_device *pdev)

rtc->da9052 = dev_get_drvdata(pdev->dev.parent);
platform_set_drvdata(pdev, rtc);
- rtc->irq = platform_get_irq_byname(pdev, "ALM");
- ret = request_threaded_irq(rtc->irq, NULL, da9052_rtc_irq,
- IRQF_TRIGGER_LOW | IRQF_ONESHOT,
- "ALM", rtc);
+ rtc->irq = DA9052_IRQ_ALARM;
+
+ ret = da9052_request_irq(rtc->da9052, rtc->irq, "ALM",
+ da9052_rtc_irq, rtc);
if (ret != 0) {
rtc_err(rtc->da9052, "irq registration failed: %d\n", ret);
return ret;
--
1.7.1

2013-03-21 15:26:04

by Greg Kroah-Hartman

Subject: Re: [patch v1]rtc: fix for DA9052/53 rtc device registration

On Thu, Mar 21, 2013 at 12:39:07PM +0530, Ashish Jangam wrote:
> This patch adds supports for the virtual irq since now MFD only handles virtual irq
> Without this patch rtc device will fail in registration.
>
> This patch is for Linux stable version 3.8.x
>
> Signed-off-by: Ashish Jangam <[email protected]>
> ---
> drivers/rtc/rtc-da9052.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

2013-03-21 21:46:43

by Andrew Morton

Subject: Re: [patch v1]rtc: fix for DA9052/53 rtc device registration

On Thu, 21 Mar 2013 08:25:57 -0700 Greg KH <[email protected]> wrote:

> On Thu, Mar 21, 2013 at 12:39:07PM +0530, Ashish Jangam wrote:
> > This patch adds supports for the virtual irq since now MFD only handles virtual irq
> > Without this patch rtc device will fail in registration.
> >
> > This patch is for Linux stable version 3.8.x
> >
> > Signed-off-by: Ashish Jangam <[email protected]>
> > ---
> > drivers/rtc/rtc-da9052.c | 8 ++++----
> > 1 files changed, 4 insertions(+), 4 deletions(-)
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
>
> </formletter>

This patch is the -stable counterpart of
http://ozlabs.org/~akpm/mmots/broken-out/drivers-rtc-rtc-da9052c-fix-for-rtc-device-registration.patch,
which I'll be sending Linuswards tomorrow, I expect.

So you'll be looking for this patch pretty soon!