2013-03-25 22:41:55

by Andreas Fenkart

Subject: [PATCH 1/1] irq: get_irq_disable_depth.

Used to verify invariant in omap_hsmmc, were a gpio is used to detect
sdio irqs during suspend phase. The ref count from irq_enable/irq_disable
is used to control when the irq should be effectively enabled.

irq en irq dis
------------------------
pm suspend | 0 | 1
pm default | 1 | 2

irq disable depth

When the sdio irq is enabled AND the module is in runtime suspend,
the ref must be zero so the irq is effectively enabled.

This function helps to verify, that the disable depth has the
right value at different driver states.

Signed-off-by: Andreas Fenkart <[email protected]>
---
include/linux/interrupt.h | 1 +
kernel/irq/manage.c | 17 +++++++++++++++++
2 files changed, 18 insertions(+)

diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 5fa5afe..d02816b 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -219,6 +219,7 @@ extern void disable_irq(unsigned int irq);
extern void disable_percpu_irq(unsigned int irq);
extern void enable_irq(unsigned int irq);
extern void enable_percpu_irq(unsigned int irq, unsigned int type);
+extern int get_irq_disable_depth(unsigned int irq);

/* The following three functions are for the core kernel use only. */
#ifdef CONFIG_GENERIC_HARDIRQS
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index fa17855..d151868 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -417,6 +417,23 @@ void disable_irq(unsigned int irq)
}
EXPORT_SYMBOL(disable_irq);

+int get_irq_disable_depth(unsigned int irq)
+{
+ int depth;
+ unsigned long flags;
+ struct irq_desc *desc = irq_get_desc_buslock(irq, &flags,
+ IRQ_GET_DESC_CHECK_GLOBAL);
+
+ if (!desc)
+ return -1;
+
+ depth = desc->depth;
+
+ irq_put_desc_busunlock(desc, flags);
+ return depth;
+}
+EXPORT_SYMBOL(get_irq_disable_depth);
+
void __enable_irq(struct irq_desc *desc, unsigned int irq, bool resume)
{
if (resume) {
--
1.7.10.4

2013-03-26 11:14:33

by Thomas Gleixner

Subject: Re: [PATCH 1/1] irq: get_irq_disable_depth.

On Mon, 25 Mar 2013, Andreas Fenkart wrote:
> Used to verify invariant in omap_hsmmc, were a gpio is used to detect
> sdio irqs during suspend phase. The ref count from irq_enable/irq_disable
> is used to control when the irq should be effectively enabled.
>
> irq en irq dis
> ------------------------
> pm suspend | 0 | 1
> pm default | 1 | 2
>
> irq disable depth
>
> When the sdio irq is enabled AND the module is in runtime suspend,
> the ref must be zero so the irq is effectively enabled.
>
> This function helps to verify, that the disable depth has the
> right value at different driver states.

I'm really not getting it. The SDIO driver knows whether it has
interrupts enabled or not, so what needs to be verified?

If you need this just to debug your driver, then please keep it in
your private tree. I really can't see a general value for this.

Thanks,

tglx