2013-03-26 01:31:38

by Damian Hobson-Garcia

Subject: [PATCH] drivers: uio: Fix UIO device registration failure

Until recently uio_get_minor() returned 0 for success and
a negative value on failure. This became non-negative for suceess and
negative for failure. Restore the original return value spec so that we can
successfully initialize UIO devices with a non-zero minor device
number.

Signed-off-by: Damian Hobson-Garcia <[email protected]>
---
drivers/uio/uio.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index c8b9262..b645c47 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -374,6 +374,7 @@ static int uio_get_minor(struct uio_device *idev)
retval = idr_alloc(&uio_idr, idev, 0, UIO_MAX_DEVICES, GFP_KERNEL);
if (retval >= 0) {
idev->minor = retval;
+ retval = 0;
} else if (retval == -ENOSPC) {
dev_err(idev->dev, "too many uio devices\n");
retval = -EINVAL;
--
1.7.5.4

2013-03-26 01:47:37

by Greg KH

Subject: Re: [PATCH] drivers: uio: Fix UIO device registration failure

On Tue, Mar 26, 2013 at 10:31:22AM +0900, Damian Hobson-Garcia wrote:
> Until recently uio_get_minor() returned 0 for success and
> a negative value on failure. This became non-negative for suceess and
> negative for failure. Restore the original return value spec so that we can
> successfully initialize UIO devices with a non-zero minor device
> number.
>
> Signed-off-by: Damian Hobson-Garcia <[email protected]>
> ---
> drivers/uio/uio.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

Hans, don't you have a bunch of uio patches queued up for me? I've been
ignoring them, thinking you are collecting them, is this not true?

greg k-h

2013-04-23 04:43:28

by Sachin Kamat

Subject: Re: [PATCH] drivers: uio: Fix UIO device registration failure

On 26 March 2013 07:17, Greg KH <[email protected]> wrote:
> On Tue, Mar 26, 2013 at 10:31:22AM +0900, Damian Hobson-Garcia wrote:
>> Until recently uio_get_minor() returned 0 for success and
>> a negative value on failure. This became non-negative for suceess and
>> negative for failure. Restore the original return value spec so that we can
>> successfully initialize UIO devices with a non-zero minor device
>> number.
>>
>> Signed-off-by: Damian Hobson-Garcia <[email protected]>
>> ---
>> drivers/uio/uio.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> Hans, don't you have a bunch of uio patches queued up for me? I've been
> ignoring them, thinking you are collecting them, is this not true?

Greg, there isn't any response from Hans regarding the UIO patches.
Would you be picking them instead?

--
With warm regards,
Sachin