2013-03-27 20:28:11

by Andrei Epure

Subject: [PATCH] video: exynos: Convert to devm_ioremap_resource()

The new devm_ioremap_resource() provides its own error messages.
Patch found using coccinelle.

Signed-off-by: Andrei Epure <[email protected]>
---
drivers/video/exynos/exynos_mipi_dsi.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c
index fac7df6..dd5e5e9 100644
--- a/drivers/video/exynos/exynos_mipi_dsi.c
+++ b/drivers/video/exynos/exynos_mipi_dsi.c
@@ -384,10 +384,9 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev)

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

- dsim->reg_base = devm_request_and_ioremap(&pdev->dev, res);
- if (!dsim->reg_base) {
- dev_err(&pdev->dev, "failed to remap io region\n");
- ret = -ENOMEM;
+ dsim->reg_base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(dsim->reg_base)) {
+ ret = PTR_ERR(dsim->reg_base);
goto error;
}

--
1.7.9.5

2013-03-27 23:53:00

by Donghwa Lee

Subject: Re: [PATCH] video: exynos: Convert to devm_ioremap_resource()

Hi,

Please refer to the following link.

http://marc.info/?l=linux-fbdev&m=135963121130437&w=2

Best regard,
Donghwa Lee

On Thu, Mar 28, 2013 at 05:28, Andrei Epure wrote:
> The new devm_ioremap_resource() provides its own error messages.
> Patch found using coccinelle.
>
> Signed-off-by: Andrei Epure <[email protected]>
> ---
> drivers/video/exynos/exynos_mipi_dsi.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c
> index fac7df6..dd5e5e9 100644
> --- a/drivers/video/exynos/exynos_mipi_dsi.c
> +++ b/drivers/video/exynos/exynos_mipi_dsi.c
> @@ -384,10 +384,9 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>
> - dsim->reg_base = devm_request_and_ioremap(&pdev->dev, res);
> - if (!dsim->reg_base) {
> - dev_err(&pdev->dev, "failed to remap io region\n");
> - ret = -ENOMEM;
> + dsim->reg_base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(dsim->reg_base)) {
> + ret = PTR_ERR(dsim->reg_base);
> goto error;
> }
>