2013-03-27 20:35:48

by Andrei Epure

[permalink] [raw]

Subject: [PATCH] video: omap2: dss: use PTR_RET function

---

Use PTR_RET function instead of IS_ERR + PTR_ERR.
Patch found using coccinelle.

Signed-off-by: Andrei Epure <[email protected]>
---
drivers/video/omap2/dss/core.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
index f8779d4..60cc6fe 100644
--- a/drivers/video/omap2/dss/core.c
+++ b/drivers/video/omap2/dss/core.c
@@ -181,10 +181,7 @@ int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *))
d = debugfs_create_file(name, S_IRUGO, dss_debugfs_dir,
write, &dss_debug_fops);

- if (IS_ERR(d))
- return PTR_ERR(d);
-
- return 0;
+ return PTR_RET(d);
}
#else /* CONFIG_OMAP2_DSS_DEBUGFS */
static inline int dss_initialize_debugfs(void)
--
1.7.9.5

2013-04-02 10:13:47

by Tomi Valkeinen

[permalink] [raw]

Subject: Re: [PATCH] video: omap2: dss: use PTR_RET function

---

Hi,

On 2013-03-27 22:35, Andrei Epure wrote:
> Use PTR_RET function instead of IS_ERR + PTR_ERR.
> Patch found using coccinelle.
>
> Signed-off-by: Andrei Epure <[email protected]>
> ---
> drivers/video/omap2/dss/core.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
> index f8779d4..60cc6fe 100644
> --- a/drivers/video/omap2/dss/core.c
> +++ b/drivers/video/omap2/dss/core.c
> @@ -181,10 +181,7 @@ int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *))
> d = debugfs_create_file(name, S_IRUGO, dss_debugfs_dir,
> write, &dss_debug_fops);
>
> - if (IS_ERR(d))
> - return PTR_ERR(d);
> -
> - return 0;
> + return PTR_RET(d);
> }
> #else /* CONFIG_OMAP2_DSS_DEBUGFS */
> static inline int dss_initialize_debugfs(void)
>

There's an identical patch from Alexandru Gheorghiu already queued.

Tomi

---

Attachments:

signature.asc (899.00 B)
OpenPGP digital signature