Subject: [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable

The imx23-olinuxino sdcard doesn't support card detect.

Signed-off-by: Alexandre Pereira da Silva <[email protected]>
---
arch/arm/boot/dts/imx23-olinuxino.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts
index e7484e4..03f55c2 100644
--- a/arch/arm/boot/dts/imx23-olinuxino.dts
+++ b/arch/arm/boot/dts/imx23-olinuxino.dts
@@ -29,6 +29,7 @@
pinctrl-names = "default";
pinctrl-0 = <&mmc0_4bit_pins_a &mmc0_pins_fixup>;
bus-width = <4>;
+ non-removable;
status = "okay";
};

--
1.7.10


2013-04-05 06:38:50

by Marek Vasut

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable

Dear Alexandre Pereira da Silva,

> The imx23-olinuxino sdcard doesn't support card detect.
>
> Signed-off-by: Alexandre Pereira da Silva <[email protected]>
> ---
> arch/arm/boot/dts/imx23-olinuxino.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts
> b/arch/arm/boot/dts/imx23-olinuxino.dts index e7484e4..03f55c2 100644
> --- a/arch/arm/boot/dts/imx23-olinuxino.dts
> +++ b/arch/arm/boot/dts/imx23-olinuxino.dts
> @@ -29,6 +29,7 @@
> pinctrl-names = "default";
> pinctrl-0 = <&mmc0_4bit_pins_a
&mmc0_pins_fixup>;
> bus-width = <4>;
> + non-removable;
> status = "okay";
> };

The card on mx23 olinuxino seems perfectly removable to me ... on all possible
models and even prototypes and hybrids too ;-)

Best regards,
Marek Vasut

2013-04-05 09:17:13

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable

On Fri, Apr 05, 2013 at 01:16:53AM -0300, Alexandre Pereira da Silva wrote:
> The imx23-olinuxino sdcard doesn't support card detect.
>
So it sounds more like a "broken-cd" rather than "non-removable"?

Shawn

> Signed-off-by: Alexandre Pereira da Silva <[email protected]>
> ---
> arch/arm/boot/dts/imx23-olinuxino.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/imx23-olinuxino.dts b/arch/arm/boot/dts/imx23-olinuxino.dts
> index e7484e4..03f55c2 100644
> --- a/arch/arm/boot/dts/imx23-olinuxino.dts
> +++ b/arch/arm/boot/dts/imx23-olinuxino.dts
> @@ -29,6 +29,7 @@
> pinctrl-names = "default";
> pinctrl-0 = <&mmc0_4bit_pins_a &mmc0_pins_fixup>;
> bus-width = <4>;
> + non-removable;
> status = "okay";
> };
>
> --
> 1.7.10
>

2013-04-05 14:13:31

by Marek Vasut

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable

Dear Shawn Guo,

> On Fri, Apr 05, 2013 at 01:16:53AM -0300, Alexandre Pereira da Silva wrote:
> > The imx23-olinuxino sdcard doesn't support card detect.
>
> So it sounds more like a "broken-cd" rather than "non-removable"?

The CD line is working perfectly well on this board, so I don't get it.

Best regards,
Marek Vasut

Subject: Re: [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable

On Fri, Apr 5, 2013 at 11:11 AM, Marek Vasut <[email protected]> wrote:
> The CD line is working perfectly well on this board, so I don't get it.

In the schematics of this board, the SSP1_DETECT pin is connected to
the green led. As I see, there is no way, the hardware can detect card
removal. Am I missing something here?

2013-04-05 16:08:20

by Marek Vasut

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: imx23-olinuxino: Set the sdcard as non-removable

Dear Alexandre Pereira da Silva,

> On Fri, Apr 5, 2013 at 11:11 AM, Marek Vasut <[email protected]> wrote:
> > The CD line is working perfectly well on this board, so I don't get it.
>
> In the schematics of this board, the SSP1_DETECT pin is connected to
> the green led. As I see, there is no way, the hardware can detect card
> removal. Am I missing something here?

You're right. Then the design is indeed defective. Sorry.

Best regards,
Marek Vasut