2013-04-08 01:47:37

by Tyrel Datwyler

[permalink] [raw]
Subject: [PATCH] Staging: omap-thermal: remove trailing whitespace from omap-bandgap.c

This patch removes trailing whitespace from a blank line in omap-bandgap.c as
detected by the checkpatch.pl tool.

Signed-off-by: Tyrel Datwyler <[email protected]>
---
drivers/staging/omap-thermal/omap-bandgap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/omap-thermal/omap-bandgap.c b/drivers/staging/omap-thermal/omap-bandgap.c
index dcc1448..e507d17 100644
--- a/drivers/staging/omap-thermal/omap-bandgap.c
+++ b/drivers/staging/omap-thermal/omap-bandgap.c
@@ -823,7 +823,7 @@ static struct omap_bandgap *omap_bandgap_build(struct platform_device *pdev)
bg_ptr->base = chunk;
if (IS_ERR(chunk))
return ERR_CAST(chunk);
-
+
i++;
} while (res);

--
1.8.1.4


2013-04-08 17:22:37

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] Staging: omap-thermal: remove trailing whitespace from omap-bandgap.c

On Sun, Apr 07, 2013 at 06:47:20PM -0700, Tyrel Datwyler wrote:
> This patch removes trailing whitespace from a blank line in omap-bandgap.c as
> detected by the checkpatch.pl tool.
>
> Signed-off-by: Tyrel Datwyler <[email protected]>
> ---
> drivers/staging/omap-thermal/omap-bandgap.c | 2 +-

This file no longer is in my tree, are you sure you made this against
the proper branch? Please always make staging patches against the
linux-next tree.

thanks,

greg k-h

2013-04-08 18:24:15

by Eduardo Valentin

[permalink] [raw]
Subject: Re: [PATCH] Staging: omap-thermal: remove trailing whitespace from omap-bandgap.c

Fixing to right email address.

On Mon, Apr 8, 2013 at 1:22 PM, Greg KH <[email protected]> wrote:
> On Sun, Apr 07, 2013 at 06:47:20PM -0700, Tyrel Datwyler wrote:
>> This patch removes trailing whitespace from a blank line in omap-bandgap.c as
>> detected by the checkpatch.pl tool.
>>
>> Signed-off-by: Tyrel Datwyler <[email protected]>
>> ---
>> drivers/staging/omap-thermal/omap-bandgap.c | 2 +-
>
> This file no longer is in my tree, are you sure you made this against
> the proper branch? Please always make staging patches against the
> linux-next tree.
>
> thanks,
>
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/



--
Eduardo Bezerra Valentin

2013-04-08 18:27:33

by Eduardo Valentin

[permalink] [raw]
Subject: Re: [PATCH] Staging: omap-thermal: remove trailing whitespace from omap-bandgap.c

Tyrel,


On 08-04-2013 14:24, [email protected] wrote:
> Fixing to right email address.
>
> On Mon, Apr 8, 2013 at 1:22 PM, Greg KH <[email protected]> wrote:
>> On Sun, Apr 07, 2013 at 06:47:20PM -0700, Tyrel Datwyler wrote:
>>> This patch removes trailing whitespace from a blank line in omap-bandgap.c as
>>> detected by the checkpatch.pl tool.
>>>
>>> Signed-off-by: Tyrel Datwyler <[email protected]>

Thanks for your patch. But as mentioned by Greg, this file does not
exist anymore, it has been renamed. Check latest linux-next.

Besides, the issue you are fixing has been already removed. Also check
latest linux-next and you will see the driver under:
drivers/staging/ti-soc-thermal/ti-bandgap.c

Thanks, please keep sending your patches and copy my email address so I
will give you a quick response.

>>> ---
>>> drivers/staging/omap-thermal/omap-bandgap.c | 2 +-
>>
>> This file no longer is in my tree, are you sure you made this against
>> the proper branch? Please always make staging patches against the
>> linux-next tree.
>>
>> thanks,
>>
>> greg k-h
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>
>
>

2013-04-08 19:12:27

by Dan Carpenter

[permalink] [raw]
Subject: Re: [PATCH] Staging: omap-thermal: remove trailing whitespace from omap-bandgap.c

On Mon, Apr 08, 2013 at 02:27:13PM -0400, Eduardo Valentin wrote:
> Thanks, please keep sending your patches and copy my email address
> so I will give you a quick response.

Please, send a patch adding yourself to the MAINTAINERS file so the
get_maintainer.pl script does the right thing automatically.

After that you will be an official kernel maintainer with all the
honor and dignity that goes along with it. :)

regards,
dan carpenter

2013-04-08 19:16:01

by Eduardo Valentin

[permalink] [raw]
Subject: Re: [PATCH] Staging: omap-thermal: remove trailing whitespace from omap-bandgap.c

On 08-04-2013 15:12, Dan Carpenter wrote:
> On Mon, Apr 08, 2013 at 02:27:13PM -0400, Eduardo Valentin wrote:
>> Thanks, please keep sending your patches and copy my email address
>> so I will give you a quick response.
>
> Please, send a patch adding yourself to the MAINTAINERS file so the
> get_maintainer.pl script does the right thing automatically.
>
> After that you will be an official kernel maintainer with all the
> honor and dignity that goes along with it. :)


In fact this has been already done. It is queued by Greg and should be
in linux-next. Probably from 3.10 onwards my name should be there.

Thanks for this hint ;-)
>
> regards,
> dan carpenter
>
>
>

2013-04-09 00:45:21

by Tyrel Datwyler

[permalink] [raw]
Subject: Re: [PATCH] Staging: omap-thermal: remove trailing whitespace from omap-bandgap.c

On 04/08/2013 11:27 AM, Eduardo Valentin wrote:
>
> Thanks for your patch. But as mentioned by Greg, this file does not
> exist anymore, it has been renamed. Check latest linux-next.
>
> Besides, the issue you are fixing has been already removed. Also check
> latest linux-next and you will see the driver under:
> drivers/staging/ti-soc-thermal/ti-bandgap.c
>
> Thanks, please keep sending your patches and copy my email address so I
> will give you a quick response.
>

So, what you guys are telling me is that linux-next and not Linus's tree
is where the action is at? I was looking for something trivial as a test
run through the submission process, and I still managed to botch it.
Noted and lesson learned.

-Tyrel