Hi Samuel,
After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
failed like this:
drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]
Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support").
I have used the mfd tree from next-20130405 for today.
--
Cheers,
Stephen Rothwell [email protected]
Hello.
> After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
> drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]
>
> Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support").
>
> I have used the mfd tree from next-20130405 for today.
This means that we do not have empty declarations for the
of_xx functions in linux/of.h for !CONFIG_OF.
OK to declare these functions or any other opinions?
---
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?
Hi Alexander,
On Mon, Apr 08, 2013 at 08:45:51AM +0400, Alexander Shiyan wrote:
> Hello.
>
> > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
> > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]
> >
> > Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support").
> >
> > I have used the mfd tree from next-20130405 for today.
>
> This means that we do not have empty declarations for the
> of_xx functions in linux/of.h for !CONFIG_OF.
> OK to declare these functions or any other opinions?
Ok with me, but you'd need to get Grant and Rob's ACK.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
> > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > >
> > > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
> > > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]
> > >
> > > Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support").
> > >
> > > I have used the mfd tree from next-20130405 for today.
> >
> > This means that we do not have empty declarations for the
> > of_xx functions in linux/of.h for !CONFIG_OF.
> > OK to declare these functions or any other opinions?
> Ok with me, but you'd need to get Grant and Rob's ACK.
I've revised my initial opinion and write a quick patch for fix this issue.
>From a884d309d2978cbc44c52b650d669e56fef664e2 Mon Sep 17 00:00:00 2001
From: Alexander Shiyan <[email protected]>
Date: Mon, 8 Apr 2013 19:13:10 +0400
Subject: [PATCH] regulator: anatop: Make select dependency from
HAVE_IMX_ANATOP symbol
This patch make selection of anatop-regulator from HAVE_IMX_ANATOP
kernel symbol. This fixes build kernel with syscon driver but without
oftree support.
Signed-off-by: Alexander Shiyan <[email protected]>
---
drivers/regulator/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index a5d97ea..078932d 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -133,7 +133,7 @@ config REGULATOR_FAN53555
config REGULATOR_ANATOP
tristate "Freescale i.MX on-chip ANATOP LDO regulators"
- depends on MFD_SYSCON
+ depends on HAVE_IMX_ANATOP
help
Say y here to support Freescale i.MX on-chip ANATOP LDOs
regulators. It is recommended that this option be
--
1.8.1.5
---
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?
Hi Alexander,
On Mon, Apr 08, 2013 at 08:27:49PM +0400, Alexander Shiyan wrote:
> > > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> > > > failed like this:
> > > >
> > > > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
> > > > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]
> > > >
> > > > Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support").
> > > >
> > > > I have used the mfd tree from next-20130405 for today.
> > >
> > > This means that we do not have empty declarations for the
> > > of_xx functions in linux/of.h for !CONFIG_OF.
> > > OK to declare these functions or any other opinions?
> > Ok with me, but you'd need to get Grant and Rob's ACK.
>
> I've revised my initial opinion and write a quick patch for fix this issue.
>
> From a884d309d2978cbc44c52b650d669e56fef664e2 Mon Sep 17 00:00:00 2001
> From: Alexander Shiyan <[email protected]>
> Date: Mon, 8 Apr 2013 19:13:10 +0400
> Subject: [PATCH] regulator: anatop: Make select dependency from
> HAVE_IMX_ANATOP symbol
>
> This patch make selection of anatop-regulator from HAVE_IMX_ANATOP
> kernel symbol. This fixes build kernel with syscon driver but without
> oftree support.
>
> Signed-off-by: Alexander Shiyan <[email protected]>
> ---
> drivers/regulator/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index a5d97ea..078932d 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -133,7 +133,7 @@ config REGULATOR_FAN53555
>
> config REGULATOR_ANATOP
> tristate "Freescale i.MX on-chip ANATOP LDO regulators"
> - depends on MFD_SYSCON
> + depends on HAVE_IMX_ANATOP
This does look like a band-aid solution to me. Yes, it will fix the crash, but
you're restricting this code to a much smaller architecture set. AFAIK
linux-next is not tested on that arch, for example.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
> On Mon, Apr 08, 2013 at 08:27:49PM +0400, Alexander Shiyan wrote:
> > > > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> > > > > failed like this:
> > > > >
> > > > > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
> > > > > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]
> > > > >
> > > > > Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support").
> > > > >
> > > > > I have used the mfd tree from next-20130405 for today.
> > > >
> > > > This means that we do not have empty declarations for the
> > > > of_xx functions in linux/of.h for !CONFIG_OF.
> > > > OK to declare these functions or any other opinions?
> > > Ok with me, but you'd need to get Grant and Rob's ACK.
...
> > Subject: [PATCH] regulator: anatop: Make select dependency from
> > HAVE_IMX_ANATOP symbol
> >
> > This patch make selection of anatop-regulator from HAVE_IMX_ANATOP
> > kernel symbol. This fixes build kernel with syscon driver but without
> > oftree support.
...
> This does look like a band-aid solution to me. Yes, it will fix the crash, but
> you're restricting this code to a much smaller architecture set. AFAIK
> linux-next is not tested on that arch, for example.
OK, the second solution:
>From 3296415f29818a430bad12c92dc65cd81e4d133f Mon Sep 17 00:00:00 2001
From: Alexander Shiyan <[email protected]>
Date: Tue, 9 Apr 2013 19:41:27 +0400
Subject: [PATCH] of: add stub of_get_parent for non-OF builds
Fixes build error on x86_64 allmodconfig, introduced by commit
5ab3a89a741f ("mfd: syscon: Add non-DT support").
drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]
Signed-off-by: Alexander Shiyan <[email protected]>
---
include/linux/of.h | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/include/linux/of.h b/include/linux/of.h
index a0f1292..9f5923f 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -353,6 +353,11 @@ static inline struct device_node *of_find_node_by_name(struct device_node *from,
return NULL;
}
+static inline struct device_node *of_get_parent(const struct device_node *node)
+{
+ return NULL;
+}
+
static inline bool of_have_populated_dt(void)
{
return false;
--
1.8.1.5
---
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?
Hi Alexander,
On Tue, Apr 09, 2013 at 07:47:40PM +0400, Alexander Shiyan wrote:
> > On Mon, Apr 08, 2013 at 08:27:49PM +0400, Alexander Shiyan wrote:
> > > > > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> > > > > > failed like this:
> > > > > >
> > > > > > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
> > > > > > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]
> > > > > >
> > > > > > Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support").
> > > > > >
> > > > > > I have used the mfd tree from next-20130405 for today.
> > > > >
> > > > > This means that we do not have empty declarations for the
> > > > > of_xx functions in linux/of.h for !CONFIG_OF.
> > > > > OK to declare these functions or any other opinions?
> > > > Ok with me, but you'd need to get Grant and Rob's ACK.
> ...
> > > Subject: [PATCH] regulator: anatop: Make select dependency from
> > > HAVE_IMX_ANATOP symbol
> > >
> > > This patch make selection of anatop-regulator from HAVE_IMX_ANATOP
> > > kernel symbol. This fixes build kernel with syscon driver but without
> > > oftree support.
> ...
> > This does look like a band-aid solution to me. Yes, it will fix the crash, but
> > you're restricting this code to a much smaller architecture set. AFAIK
> > linux-next is not tested on that arch, for example.
>
> OK, the second solution:
>
> From 3296415f29818a430bad12c92dc65cd81e4d133f Mon Sep 17 00:00:00 2001
> From: Alexander Shiyan <[email protected]>
> Date: Tue, 9 Apr 2013 19:41:27 +0400
> Subject: [PATCH] of: add stub of_get_parent for non-OF builds
>
> Fixes build error on x86_64 allmodconfig, introduced by commit
> 5ab3a89a741f ("mfd: syscon: Add non-DT support").
>
> drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
> drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Alexander Shiyan <[email protected]>
> ---
> include/linux/of.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index a0f1292..9f5923f 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -353,6 +353,11 @@ static inline struct device_node *of_find_node_by_name(struct device_node *from,
> return NULL;
> }
>
> +static inline struct device_node *of_get_parent(const struct device_node *node)
> +{
> + return NULL;
> +}
> +
That looks like a proper fix, but I'd like to get Grant or/and Rob's ACK for
it before merging it. Please look at MAINTAINERS and cc them on this thread.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
On Tue, Apr 9, 2013 at 11:12 AM, Samuel Ortiz <[email protected]> wrote:
> Hi Alexander,
>
> On Tue, Apr 09, 2013 at 07:47:40PM +0400, Alexander Shiyan wrote:
>> > On Mon, Apr 08, 2013 at 08:27:49PM +0400, Alexander Shiyan wrote:
[...]
>> From 3296415f29818a430bad12c92dc65cd81e4d133f Mon Sep 17 00:00:00 2001
>> From: Alexander Shiyan <[email protected]>
>> Date: Tue, 9 Apr 2013 19:41:27 +0400
>> Subject: [PATCH] of: add stub of_get_parent for non-OF builds
>>
>> Fixes build error on x86_64 allmodconfig, introduced by commit
>> 5ab3a89a741f ("mfd: syscon: Add non-DT support").
>>
>> drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
>> drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]
>>
>> Signed-off-by: Alexander Shiyan <[email protected]>
>> ---
>> include/linux/of.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/include/linux/of.h b/include/linux/of.h
>> index a0f1292..9f5923f 100644
>> --- a/include/linux/of.h
>> +++ b/include/linux/of.h
>> @@ -353,6 +353,11 @@ static inline struct device_node *of_find_node_by_name(struct device_node *from,
>> return NULL;
>> }
>>
>> +static inline struct device_node *of_get_parent(const struct device_node *node)
>> +{
>> + return NULL;
>> +}
>> +
> That looks like a proper fix, but I'd like to get Grant or/and Rob's ACK for
> it before merging it. Please look at MAINTAINERS and cc them on this thread.
Acked-by: Rob Herring <[email protected]>
Hi Rob,
On Tue, Apr 09, 2013 at 11:50:30AM -0500, Rob Herring wrote:
> On Tue, Apr 9, 2013 at 11:12 AM, Samuel Ortiz <[email protected]> wrote:
> >
> > On Tue, Apr 09, 2013 at 07:47:40PM +0400, Alexander Shiyan wrote:
> >> > On Mon, Apr 08, 2013 at 08:27:49PM +0400, Alexander Shiyan wrote:
>
> [...]
>
> >> From 3296415f29818a430bad12c92dc65cd81e4d133f Mon Sep 17 00:00:00 2001
> >> From: Alexander Shiyan <[email protected]>
> >> Date: Tue, 9 Apr 2013 19:41:27 +0400
> >> Subject: [PATCH] of: add stub of_get_parent for non-OF builds
> >>
> >> Fixes build error on x86_64 allmodconfig, introduced by commit
> >> 5ab3a89a741f ("mfd: syscon: Add non-DT support").
> >>
> >> drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
> >> drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]
> >>
> >> Signed-off-by: Alexander Shiyan <[email protected]>
> >> ---
> >> include/linux/of.h | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/include/linux/of.h b/include/linux/of.h
> >> index a0f1292..9f5923f 100644
> >> --- a/include/linux/of.h
> >> +++ b/include/linux/of.h
> >> @@ -353,6 +353,11 @@ static inline struct device_node *of_find_node_by_name(struct device_node *from,
> >> return NULL;
> >> }
> >>
> >> +static inline struct device_node *of_get_parent(const struct device_node *node)
> >> +{
> >> + return NULL;
> >> +}
> >> +
> > That looks like a proper fix, but I'd like to get Grant or/and Rob's ACK for
> > it before merging it. Please look at MAINTAINERS and cc them on this thread.
>
> Acked-by: Rob Herring <[email protected]>
Thanks, I am pushing this patch through the mfd-next tree.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/