2013-04-10 20:59:43

by Silviu-Mihai Popescu

Subject: [PATCH] drivers: media: platform: convert to devm_ioremap_resource()

Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.

Signed-off-by: Silviu-Mihai Popescu <[email protected]>
---
drivers/media/platform/sh_veu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/platform/sh_veu.c b/drivers/media/platform/sh_veu.c
index cb54c69..911f562 100644
--- a/drivers/media/platform/sh_veu.c
+++ b/drivers/media/platform/sh_veu.c
@@ -1164,9 +1164,9 @@ static int sh_veu_probe(struct platform_device *pdev)

veu->is_2h = resource_size(reg_res) == 0x22c;

- veu->base = devm_request_and_ioremap(&pdev->dev, reg_res);
- if (!veu->base)
- return -ENOMEM;
+ veu->base = devm_ioremap_resource(&pdev->dev, reg_res);
+ if (IS_ERR(veu->base))
+ return PTR_ERR(veu->base);

ret = devm_request_threaded_irq(&pdev->dev, irq, sh_veu_isr, sh_veu_bh,
0, "veu", veu);
--
1.7.9.5

2013-04-12 12:38:46

by Guennadi Liakhovetski

Subject: Re: [PATCH] drivers: media: platform: convert to devm_ioremap_resource()

Hi

On Wed, 10 Apr 2013, Silviu-Mihai Popescu wrote:

> Convert all uses of devm_request_and_ioremap() to the newly introduced
> devm_ioremap_resource() which provides more consistent error handling.
>
> Signed-off-by: Silviu-Mihai Popescu <[email protected]>

Thanks for the patch, but an equivalent one is already upstream:

http://git.linuxtv.org/media_tree.git/commitdiff/f2b4dc1a0fc8f52e06025497ce9bb252ff51f15f

Thanks
Guennadi

> ---
> drivers/media/platform/sh_veu.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/sh_veu.c b/drivers/media/platform/sh_veu.c
> index cb54c69..911f562 100644
> --- a/drivers/media/platform/sh_veu.c
> +++ b/drivers/media/platform/sh_veu.c
> @@ -1164,9 +1164,9 @@ static int sh_veu_probe(struct platform_device *pdev)
>
> veu->is_2h = resource_size(reg_res) == 0x22c;
>
> - veu->base = devm_request_and_ioremap(&pdev->dev, reg_res);
> - if (!veu->base)
> - return -ENOMEM;
> + veu->base = devm_ioremap_resource(&pdev->dev, reg_res);
> + if (IS_ERR(veu->base))
> + return PTR_ERR(veu->base);
>
> ret = devm_request_threaded_irq(&pdev->dev, irq, sh_veu_isr, sh_veu_bh,
> 0, "veu", veu);
> --
> 1.7.9.5
>

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/