2013-04-13 14:13:07

by Jonas Gorski

Subject: [PATCH] checkpatch: whitelist SUPPORTED_*/ADVERTISED_* defines from ethtool.h

Don't complain about camelcase when using SUPPORTED_*/ADVERTISED_*
defines, they are part of the user api so can't be (easily) fixed.

Removes false positives in e.g. ethernet drivers like:

WARNING: Avoid CamelCase: <SUPPORTED_Autoneg>
+ SUPPORTED_Autoneg |

Signed-off-by: Jonas Gorski <[email protected]>
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b28cc38..349559a4 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2931,6 +2931,7 @@ sub process {
if ($var !~ /$Constant/ &&
$var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
$var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
+ $var !~ /^(?:SUPPORTED|ADVERTISED)_\w*/ &&
!defined $camelcase{$var}) {
$camelcase{$var} = 1;
WARN("CAMELCASE",
--
1.7.10.4

2013-04-13 19:05:45

by Joe Perches

Subject: Re: [PATCH] checkpatch: whitelist SUPPORTED_*/ADVERTISED_* defines from ethtool.h

On Sat, 2013-04-13 at 16:10 +0200, Jonas Gorski wrote:
> Don't complain about camelcase when using SUPPORTED_*/ADVERTISED_*
> defines, they are part of the user api so can't be (easily) fixed.

CamelCase was downgraded recently to a --strict test.

https://lkml.org/lkml/2013/4/11/273

Still, there's a large quantity of CamelCase names in
include/... that would still exist in any case.

A complete whitelist would be very long.