2013-04-17 07:16:37

by Yijing Wang

Subject: [PATCH] mm: fix build warning about kernel_physical_mapping_remove()

If CONFIG_MEMORY_HOTREMOVE is not set, a build warning about
"warning: ‘kernel_physical_mapping_remove’ defined but not used"
report.

Signed-off-by: Yijing Wang <[email protected]>
Cc: Tang Chen <[email protected]>
Cc: Wen Congyang <[email protected]>
---
arch/x86/mm/init_64.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index 474e28f..dafdeb2 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -1019,6 +1019,7 @@ void __ref vmemmap_free(struct page *memmap, unsigned long nr_pages)
remove_pagetable(start, end, false);
}

+#ifdef CONFIG_MEMORY_HOTREMOVE
static void __meminit
kernel_physical_mapping_remove(unsigned long start, unsigned long end)
{
@@ -1028,7 +1029,6 @@ kernel_physical_mapping_remove(unsigned long start, unsigned long end)
remove_pagetable(start, end, true);
}

-#ifdef CONFIG_MEMORY_HOTREMOVE
int __ref arch_remove_memory(u64 start, u64 size)
{
unsigned long start_pfn = start >> PAGE_SHIFT;
--
1.7.1

2013-04-17 07:39:01

by Yijing Wang

Subject: Re: [PATCH] mm: fix build warning about kernel_physical_mapping_remove()

On 2013/4/17 15:22, Wanpeng Li wrote:
> On Wed, Apr 17, 2013 at 03:15:58PM +0800, Yijing Wang wrote:
>> If CONFIG_MEMORY_HOTREMOVE is not set, a build warning about
>> "warning: ‘kernel_physical_mapping_remove’ defined but not used"
>> report.
>>
>
> This has already been fixed by Tang Chen.
> http://marc.info/?l=linux-mm&m=136614697618243&w=2

OK, I will drop this one, thanks!

>
>> Signed-off-by: Yijing Wang <[email protected]>
>> Cc: Tang Chen <[email protected]>
>> Cc: Wen Congyang <[email protected]>
>> ---
>> arch/x86/mm/init_64.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>> index 474e28f..dafdeb2 100644
>> --- a/arch/x86/mm/init_64.c
>> +++ b/arch/x86/mm/init_64.c
>> @@ -1019,6 +1019,7 @@ void __ref vmemmap_free(struct page *memmap, unsigned long nr_pages)
>> remove_pagetable(start, end, false);
>> }
>>
>> +#ifdef CONFIG_MEMORY_HOTREMOVE
>> static void __meminit
>> kernel_physical_mapping_remove(unsigned long start, unsigned long end)
>> {
>> @@ -1028,7 +1029,6 @@ kernel_physical_mapping_remove(unsigned long start, unsigned long end)
>> remove_pagetable(start, end, true);
>> }
>>
>> -#ifdef CONFIG_MEMORY_HOTREMOVE
>> int __ref arch_remove_memory(u64 start, u64 size)
>> {
>> unsigned long start_pfn = start >> PAGE_SHIFT;
>> --
>> 1.7.1
>>
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to [email protected]. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
>
>
> .
>


--
Thanks!
Yijing