2013-04-20 16:35:38

by Axel Lin

[permalink] [raw]
Subject: [PATCH 1/2] regulator: lp3971: Convert to use regulator_map_voltage_ascend

All regulators have ascendant voltage list in this driver.
Thus use regulator_map_voltage_ascend is more efficient than the default
regulator_map_voltage_iterate.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/lp3971.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c
index 9cb2c0f..d8af9e7 100644
--- a/drivers/regulator/lp3971.c
+++ b/drivers/regulator/lp3971.c
@@ -163,6 +163,7 @@ static int lp3971_ldo_set_voltage_sel(struct regulator_dev *dev,

static struct regulator_ops lp3971_ldo_ops = {
.list_voltage = regulator_list_voltage_table,
+ .map_voltage = regulator_map_voltage_ascend,
.is_enabled = lp3971_ldo_is_enabled,
.enable = lp3971_ldo_enable,
.disable = lp3971_ldo_disable,
@@ -236,6 +237,7 @@ static int lp3971_dcdc_set_voltage_sel(struct regulator_dev *dev,

static struct regulator_ops lp3971_dcdc_ops = {
.list_voltage = regulator_list_voltage_table,
+ .map_voltage = regulator_map_voltage_ascend,
.is_enabled = lp3971_dcdc_is_enabled,
.enable = lp3971_dcdc_enable,
.disable = lp3971_dcdc_disable,
--
1.7.10.4



2013-04-20 16:37:02

by Axel Lin

[permalink] [raw]
Subject: [PATCH 2/2] regulator: lp3972: Convert to use regulator_map_voltage_ascend

All regulators have ascendant voltage list in this driver.
Thus use regulator_map_voltage_ascend is more efficient than the default
regulator_map_voltage_iterate.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/lp3972.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/regulator/lp3972.c b/drivers/regulator/lp3972.c
index 0baabcf..61e4cf9 100644
--- a/drivers/regulator/lp3972.c
+++ b/drivers/regulator/lp3972.c
@@ -309,6 +309,7 @@ static int lp3972_ldo_set_voltage_sel(struct regulator_dev *dev,

static struct regulator_ops lp3972_ldo_ops = {
.list_voltage = regulator_list_voltage_table,
+ .map_voltage = regulator_map_voltage_ascend,
.is_enabled = lp3972_ldo_is_enabled,
.enable = lp3972_ldo_enable,
.disable = lp3972_ldo_disable,
@@ -389,6 +390,7 @@ static int lp3972_dcdc_set_voltage_sel(struct regulator_dev *dev,

static struct regulator_ops lp3972_dcdc_ops = {
.list_voltage = regulator_list_voltage_table,
+ .map_voltage = regulator_map_voltage_ascend,
.is_enabled = lp3972_dcdc_is_enabled,
.enable = lp3972_dcdc_enable,
.disable = lp3972_dcdc_disable,
--
1.7.10.4


2013-04-22 14:28:59

by Marek Szyprowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] regulator: lp3971: Convert to use regulator_map_voltage_ascend

Hello,

On 2013-04-20 18:35, Axel Lin wrote:
> All regulators have ascendant voltage list in this driver.
> Thus use regulator_map_voltage_ascend is more efficient than the default
> regulator_map_voltage_iterate.
>
> Signed-off-by: Axel Lin <[email protected]>

Acked-by: Marek Szyprowski <[email protected]>

> ---
> drivers/regulator/lp3971.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c
> index 9cb2c0f..d8af9e7 100644
> --- a/drivers/regulator/lp3971.c
> +++ b/drivers/regulator/lp3971.c
> @@ -163,6 +163,7 @@ static int lp3971_ldo_set_voltage_sel(struct regulator_dev *dev,
>
> static struct regulator_ops lp3971_ldo_ops = {
> .list_voltage = regulator_list_voltage_table,
> + .map_voltage = regulator_map_voltage_ascend,
> .is_enabled = lp3971_ldo_is_enabled,
> .enable = lp3971_ldo_enable,
> .disable = lp3971_ldo_disable,
> @@ -236,6 +237,7 @@ static int lp3971_dcdc_set_voltage_sel(struct regulator_dev *dev,
>
> static struct regulator_ops lp3971_dcdc_ops = {
> .list_voltage = regulator_list_voltage_table,
> + .map_voltage = regulator_map_voltage_ascend,
> .is_enabled = lp3971_dcdc_is_enabled,
> .enable = lp3971_dcdc_enable,
> .disable = lp3971_dcdc_disable,

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center

2013-04-23 10:40:01

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 1/2] regulator: lp3971: Convert to use regulator_map_voltage_ascend

On Sun, Apr 21, 2013 at 12:35:31AM +0800, Axel Lin wrote:
> All regulators have ascendant voltage list in this driver.
> Thus use regulator_map_voltage_ascend is more efficient than the default
> regulator_map_voltage_iterate.

Applied both, thanks.


Attachments:
(No filename) (250.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments