2013-05-03 15:46:41

by Alexandru Gheorghiu

Subject: [PATCH] drivers: parport: Use kmemdup

Used kmemdup instead of kmalloc and memcpy.
Patch found using coccinelle.

Signed-off-by: Alexandru Gheorghiu <[email protected]>
---
drivers/parport/parport_gsc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/parport/parport_gsc.c b/drivers/parport/parport_gsc.c
index 050773c..4b364c6 100644
--- a/drivers/parport/parport_gsc.c
+++ b/drivers/parport/parport_gsc.c
@@ -246,14 +246,14 @@ struct parport *parport_gsc_probe_port(unsigned long base,
printk (KERN_DEBUG "parport (0x%lx): no memory!\n", base);
return NULL;
}
- ops = kmalloc (sizeof (struct parport_operations), GFP_KERNEL);
+ ops = kmemdup(&parport_gsc_ops, sizeof(struct parport_operations),
+ GFP_KERNEL);
if (!ops) {
printk (KERN_DEBUG "parport (0x%lx): no memory for ops!\n",
base);
kfree (priv);
return NULL;
}
- memcpy (ops, &parport_gsc_ops, sizeof (struct parport_operations));
priv->ctr = 0xc;
priv->ctr_writable = 0xff;
priv->dma_buf = 0;
--
1.7.9.5

2013-05-17 03:56:36

by Greg Kroah-Hartman

Subject: Re: [PATCH] drivers: parport: Use kmemdup

On Sun, Apr 28, 2013 at 07:54:38PM +0300, Alexandru Gheorghiu wrote:
> Used kmemdup instead of kmalloc and memcpy.
> Patch found using coccinelle.
>
> Signed-off-by: Alexandru Gheorghiu <[email protected]>
> ---
> drivers/parport/parport_gsc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

This patch doesn't apply to my tree, care to redo it and resend it?

thanks,

greg k-h