2013-05-08 11:18:24

by Sachin Kamat

[permalink] [raw]
Subject: [PATCH 1/1] regulator: dbx500: Make local symbol static

power_state_active_get is used only in this file. Make it static.
While at it also move this function definition inside the
CONFIG_REGULATOR_DEBUG macro as it is called only from within it.
This also avoids further build warning related to unused definition.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/regulator/dbx500-prcmu.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/regulator/dbx500-prcmu.c b/drivers/regulator/dbx500-prcmu.c
index 89bd2fa..ce89f78 100644
--- a/drivers/regulator/dbx500-prcmu.c
+++ b/drivers/regulator/dbx500-prcmu.c
@@ -24,18 +24,6 @@
static int power_state_active_cnt; /* will initialize to zero */
static DEFINE_SPINLOCK(power_state_active_lock);

-int power_state_active_get(void)
-{
- unsigned long flags;
- int cnt;
-
- spin_lock_irqsave(&power_state_active_lock, flags);
- cnt = power_state_active_cnt;
- spin_unlock_irqrestore(&power_state_active_lock, flags);
-
- return cnt;
-}
-
void power_state_active_enable(void)
{
unsigned long flags;
@@ -65,6 +53,18 @@ out:

#ifdef CONFIG_REGULATOR_DEBUG

+static int power_state_active_get(void)
+{
+ unsigned long flags;
+ int cnt;
+
+ spin_lock_irqsave(&power_state_active_lock, flags);
+ cnt = power_state_active_cnt;
+ spin_unlock_irqrestore(&power_state_active_lock, flags);
+
+ return cnt;
+}
+
static struct ux500_regulator_debug {
struct dentry *dir;
struct dentry *status_file;
--
1.7.9.5


2013-05-08 12:43:20

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 1/1] regulator: dbx500: Make local symbol static

On Wed, May 08, 2013 at 04:35:10PM +0530, Sachin Kamat wrote:
> power_state_active_get is used only in this file. Make it static.
> While at it also move this function definition inside the
> CONFIG_REGULATOR_DEBUG macro as it is called only from within it.
> This also avoids further build warning related to unused definition.

Applied, thanks.


Attachments:
(No filename) (347.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments