2013-05-08 15:26:30

by Phil Carmody

Subject: [PATCH] Makefile: make sparse (CHECK) user-selectable

I've got a tweaked version as well as the system default,
so make the sparse binary that's run user-selectable.

Signed-off-by: Phil Carmody <[email protected]>
---
Makefile | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index a3a834b..e7a4851 100644
--- a/Makefile
+++ b/Makefile
@@ -338,7 +338,9 @@ GENKSYMS = scripts/genksyms/genksyms
INSTALLKERNEL := installkernel
DEPMOD = /sbin/depmod
PERL = perl
-CHECK = sparse
+ifndef CHECK
+ CHECK = sparse
+endif

CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ \
-Wbitwise -Wno-return-void $(CF)
--
1.7.2.5

2013-05-08 17:44:46

by Randy Dunlap

Subject: Re: [PATCH] Makefile: make sparse (CHECK) user-selectable

On 05/08/13 08:23, Phil Carmody wrote:
> I've got a tweaked version as well as the system default,
> so make the sparse binary that's run user-selectable.
>

I'm confused about why this patch is necessary since I already do

$ make O=builddir CHECK=/path/to/sparse all

> Signed-off-by: Phil Carmody <[email protected]>
> ---
> Makefile | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index a3a834b..e7a4851 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -338,7 +338,9 @@ GENKSYMS = scripts/genksyms/genksyms
> INSTALLKERNEL := installkernel
> DEPMOD = /sbin/depmod
> PERL = perl
> -CHECK = sparse
> +ifndef CHECK
> + CHECK = sparse
> +endif
>
> CHECKFLAGS := -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ \
> -Wbitwise -Wno-return-void $(CF)
>


--
~Randy

2013-05-10 02:45:45

by Phil Carmody

Subject: Re: [PATCH] Makefile: make sparse (CHECK) user-selectable

On 08/05/13 10:44 -0700, Randy Dunlap wrote:
> On 05/08/13 08:23, Phil Carmody wrote:
> > I've got a tweaked version as well as the system default,
> > so make the sparse binary that's run user-selectable.
> >
>
> I'm confused about why this patch is necessary since I already do
>
> $ make O=builddir CHECK=/path/to/sparse all

Ach, OK. I was presuming that I should be able to select my sparse
in the same way that I select my cross compiler, namely in the ENV.

CROSS_COMPILE=whatever- CHECK=/my/sparse make C=1

Doctor - it hurts when I do >this<, ouch.
Well, don't do that then!

Phil
--
"In a world of magnets and miracles"
-- Insane Clown Posse, Miracles, 2009. Much derided.
"Magnets, how do they work"
-- Pink Floyd, High Hopes, 1994. Lauded as lyrical geniuses.