by Michal Simek

[permalink] [raw]

Subject: Re: [PATCH v2 1/5] tty: xuartps: Remove suspend/resume functions

Hi Greg,

can you please add this patch to your tree?
It is unrelated to clk changes which Soren sent.

Thanks,
Michal

On 05/13/2013 07:46 PM, Soren Brinkmann wrote:
> Currently Zynq does not support suspend/resume.
> The driver callbacks are never used or tested, broken and using the old
> PM interface.
>
> Signed-off-by: Soren Brinkmann <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Jiri Slaby <[email protected]>
> Cc: [email protected]
> ---
> drivers/tty/serial/xilinx_uartps.c | 30 ------------------------------
> 1 file changed, 30 deletions(-)
>
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index 4e5c778..b5f655d 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -1006,34 +1006,6 @@ static int xuartps_remove(struct platform_device *pdev)
> return rc;
> }
>
> -/**
> - * xuartps_suspend - suspend event
> - * @pdev: Pointer to the platform device structure
> - * @state: State of the device
> - *
> - * Returns 0
> - **/
> -static int xuartps_suspend(struct platform_device *pdev, pm_message_t state)
> -{
> - /* Call the API provided in serial_core.c file which handles
> - * the suspend.
> - */
> - uart_suspend_port(&xuartps_uart_driver, &xuartps_port[pdev->id]);
> - return 0;
> -}
> -
> -/**
> - * xuartps_resume - Resume after a previous suspend
> - * @pdev: Pointer to the platform device structure
> - *
> - * Returns 0
> - **/
> -static int xuartps_resume(struct platform_device *pdev)
> -{
> - uart_resume_port(&xuartps_uart_driver, &xuartps_port[pdev->id]);
> - return 0;
> -}
> -
> /* Match table for of_platform binding */
> static struct of_device_id xuartps_of_match[] = {
> { .compatible = "xlnx,xuartps", },
> @@ -1044,8 +1016,6 @@ MODULE_DEVICE_TABLE(of, xuartps_of_match);
> static struct platform_driver xuartps_platform_driver = {
> .probe = xuartps_probe, /* Probe method */
> .remove = xuartps_remove, /* Detach method */
> - .suspend = xuartps_suspend, /* Suspend */
> - .resume = xuartps_resume, /* Resume after a suspend */
> .driver = {
> .owner = THIS_MODULE,
> .name = XUARTPS_NAME, /* Driver name */
>

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

Attachments:

signature.asc (263.00 B)
OpenPGP digital signature

2013-05-17 12:14:53

On 05/30/2013 08:44 PM, Mike Turquette wrote:
> Quoting Michal Simek (2013-05-17 05:14:47)
>> Hi Mike,
>>
>> I have sent email to Greg to take this patch from this series
>> though his serial tree because it is unrelated to this clock stuff.
>>
>> Can you please give me your ACK for these patches or add them
>> to your CLK tree?
>>
>
> For the four clock-related patches:
>
> Acked-by: Mike Turquette <[email protected]>

I have already sent pull request to Arnd and Olof.
Or is it you who should take these patches through your tree?

Thanks.
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

Attachments:

signature.asc (263.00 B)
OpenPGP digital signature

2013-05-31 07:03:43

by Michal Simek

[permalink] [raw]

Subject: Re: [PATCH v2 0/5] Zynq: revised CCF code

On 05/31/2013 08:32 AM, Mike Turquette wrote:
> Quoting Michal Simek (2013-05-30 22:17:59)
>> On 05/30/2013 08:44 PM, Mike Turquette wrote:
>>> Quoting Michal Simek (2013-05-17 05:14:47)
>>>> Hi Mike,
>>>>
>>>> I have sent email to Greg to take this patch from this series
>>>> though his serial tree because it is unrelated to this clock stuff.
>>>>
>>>> Can you please give me your ACK for these patches or add them
>>>> to your CLK tree?
>>>>
>>>
>>> For the four clock-related patches:
>>>
>>> Acked-by: Mike Turquette <[email protected]>
>>
>> I have already sent pull request to Arnd and Olof.
>> Or is it you who should take these patches through your tree?
>>
>
> Either way is fine. Since you have already sent the pull request to the
> arm-soc tree then that is probably the best path.

ok. I will keep my eyes on it.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

Attachments:

signature.asc (263.00 B)
OpenPGP digital signature