2013-05-14 16:46:56

by Cody P Schafer

Subject: [PATCH] checkpatch: avoid warning on page flag acessors

Using Page*() triggers a camelcase warning, but shouldn't.

Introduced by be987d9f80354e2e919926349282facd74992f90, which added the
other Page flag users.

Pipe ('|') at the end of a grouping doesn't cause the grouping to match
an emtpy string, use ? after the grouping instead to get the desired
behavior.

Signed-off-by: Cody P Schafer <[email protected]>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b954de5..ee24026 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2939,7 +2939,7 @@ sub process {
my $var = $1;
if ($var !~ /$Constant/ &&
$var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
- $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
+ $var !~ /"^(?:Clear|Set|TestClear|TestSet)?Page[A-Z]/ &&
!defined $camelcase{$var}) {
$camelcase{$var} = 1;
WARN("CAMELCASE",
--
1.8.2.2

2013-05-14 16:59:16

by Cody P Schafer

Subject: Re: [PATCH] checkpatch: avoid warning on page flag acessors

On 05/14/2013 09:45 AM, Cody P Schafer wrote:
> Using Page*() triggers a camelcase warning, but shouldn't.
>
> Introduced by be987d9f80354e2e919926349282facd74992f90, which added the
> other Page flag users.
>
> Pipe ('|') at the end of a grouping doesn't cause the grouping to match
> an emtpy string, use ? after the grouping instead to get the desired
> behavior.
>
> Signed-off-by: Cody P Schafer <[email protected]>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index b954de5..ee24026 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2939,7 +2939,7 @@ sub process {
> my $var = $1;
> if ($var !~ /$Constant/ &&
> $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
> - $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
> + $var !~ /"^(?:Clear|Set|TestClear|TestSet)?Page[A-Z]/ &&
> !defined $camelcase{$var}) {
> $camelcase{$var} = 1;
> WARN("CAMELCASE",
>


Nix this, appears to still be broken

WARNING: Avoid CamelCase: <PageBuddy>
#51: FILE: mm/page_alloc.c:449:
+ VM_BUG_ON(!PageBuddy(page));

total: 0 errors, 1 warnings, 46 lines checked

/home/cody/mm/0008-page_alloc-add-return_pages_to_zone-when-DYNAMIC_NUM.patch has style problems, please review.

2013-05-14 17:07:27

by Cody P Schafer

Subject: [PATCH v2] checkpatch: avoid warning on page flag acessors

Using Page*() triggers a camelcase warning, but shouldn't.

be987d9f80354e2e919926349282facd74992f90 added a spurious '"' (double
quote) breaking the regex.

Signed-off-by: Cody P Schafer <[email protected]>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b954de5..ee24026 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2939,7 +2939,7 @@ sub process {
my $var = $1;
if ($var !~ /$Constant/ &&
$var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
- $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
+ $var !~ /"^(?:Clear|Set|TestClear|TestSet)?Page[A-Z]/ &&
!defined $camelcase{$var}) {
$camelcase{$var} = 1;
WARN("CAMELCASE",
--
1.8.2.2

2013-05-14 17:09:24

by Cody P Schafer

Subject: [PATCH v3] checkpatch: avoid warning on page flag acessors

Using Page*() triggers a camelcase warning, but shouldn't.

be987d9f80354e2e919926349282facd74992f90 added a spurious '"' (double
quote) breaking the regex.

Signed-off-by: Cody P Schafer <[email protected]>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

---

Appologies for the noise, I updated my commit message but not the patch in the previous version.

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b954de5..ee24026 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2939,7 +2939,7 @@ sub process {
my $var = $1;
if ($var !~ /$Constant/ &&
$var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
- $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
+ $var !~ /"^(?:Clear|Set|TestClear|TestSet)?Page[A-Z]/ &&
!defined $camelcase{$var}) {
$camelcase{$var} = 1;
WARN("CAMELCASE",
--
1.8.2.2

2013-05-14 17:13:20

by Joe Perches

Subject: Re: [PATCH v2] checkpatch: avoid warning on page flag acessors

[]On Tue, 2013-05-14 at 10:06 -0700, Cody P Schafer wrote:
> Using Page*() triggers a camelcase warning, but shouldn't.
>
> be987d9f80354e2e919926349282facd74992f90 added a spurious '"' (double
> quote) breaking the regex.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2939,7 +2939,7 @@ sub process {
> my $var = $1;
> if ($var !~ /$Constant/ &&
> $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
> - $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
> + $var !~ /"^(?:Clear|Set|TestClear|TestSet)?Page[A-Z]/ &&

I think you need to delete the ", leave the | and remove the ?
Dunno where that " came from.

2013-05-14 17:16:30

by Cody P Schafer

Subject: Re: [PATCH v2] checkpatch: avoid warning on page flag acessors

On 05/14/2013 10:13 AM, Joe Perches wrote:
> I think you need to delete the ", leave the | and remove the ?
> Dunno where that " came from.

Ya. commit goof on my part, see v3

2013-05-14 17:17:51

by Cody P Schafer

Subject: [PATCH v4] checkpatch: avoid warning on page flag acessors

Using Page*() triggers a camelcase warning, but shouldn't.

be987d9f80354e2e919926349282facd74992f90 added a spurious '"' (double
quote) breaking the regex.

Signed-off-by: Cody P Schafer <[email protected]>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

---
And using sha1s in format-patch means I have to actually copy the new ones. (Again, sorry).

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b954de5..d2fe01d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2939,7 +2939,7 @@ sub process {
my $var = $1;
if ($var !~ /$Constant/ &&
$var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
- $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
+ $var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
!defined $camelcase{$var}) {
$camelcase{$var} = 1;
WARN("CAMELCASE",
--
1.8.2.2