2013-05-15 03:20:18

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the final tree (in Linus' tree)

Hi ,

After merging the final tree, today's linux-next build (i386 defconfig)
produced this warning:

kernel/auditfilter.c: In function 'audit_data_to_entry':
kernel/auditfilter.c:426:3: warning: this decimal constant is unsigned only in ISO C90 [enabled by default]

Introduced by commit 780a7654cee8 ("audit: Make testing for a valid
loginuid explicit") from Linus' tree.

--
Cheers,
Stephen Rothwell [email protected]


Attachments:
(No filename) (444.00 B)
(No filename) (836.00 B)
Download all attachments

2013-05-15 13:32:49

by Eric Paris

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the final tree (in Linus' tree)

On Wed, 2013-05-15 at 13:20 +1000, Stephen Rothwell wrote:
> Hi ,
>
> After merging the final tree, today's linux-next build (i386 defconfig)
> produced this warning:
>
> kernel/auditfilter.c: In function 'audit_data_to_entry':
> kernel/auditfilter.c:426:3: warning: this decimal constant is unsigned only in ISO C90 [enabled by default]
>
> Introduced by commit 780a7654cee8 ("audit: Make testing for a valid
> loginuid explicit") from Linus' tree.

Thank you, I'll fix it up. What am I likely missing that I don't see it
on my builds? I'm using gcc 4.8. Is there a config option that enables
additional warnings?

2013-05-15 22:25:34

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the final tree (in Linus' tree)

Hi Eric,

On Wed, May 15, 2013 at 09:32:42AM -0400, Eric Paris wrote:
> On Wed, 2013-05-15 at 13:20 +1000, Stephen Rothwell wrote:
> >
> > After merging the final tree, today's linux-next build (i386 defconfig)
> > produced this warning:
> >
> > kernel/auditfilter.c: In function 'audit_data_to_entry':
> > kernel/auditfilter.c:426:3: warning: this decimal constant is unsigned only in ISO C90 [enabled by default]
> >
> > Introduced by commit 780a7654cee8 ("audit: Make testing for a valid
> > loginuid explicit") from Linus' tree.
>
> Thank you, I'll fix it up. What am I likely missing that I don't see it
> on my builds? I'm using gcc 4.8. Is there a config option that enables
> additional warnings?

I don't think so, I am still using gcc 4.6 for this build but it is a
32 bit build ...

--
Cheers,
Stephen Rothwell

2013-05-17 05:17:41

by Viresh Kumar

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the final tree (in Linus' tree)

On Wed, May 15, 2013 at 7:02 PM, Eric Paris <[email protected]> wrote:
> On Wed, 2013-05-15 at 13:20 +1000, Stephen Rothwell wrote:
>> Hi ,
>>
>> After merging the final tree, today's linux-next build (i386 defconfig)
>> produced this warning:
>>
>> kernel/auditfilter.c: In function 'audit_data_to_entry':
>> kernel/auditfilter.c:426:3: warning: this decimal constant is unsigned only in ISO C90 [enabled by default]
>>
>> Introduced by commit 780a7654cee8 ("audit: Make testing for a valid
>> loginuid explicit") from Linus' tree.
>
> Thank you, I'll fix it up. What am I likely missing that I don't see it
> on my builds? I'm using gcc 4.8. Is there a config option that enables
> additional warnings?

Is this fixed? I couldn't find a relevant patch in linux-next/master for it.

2013-05-17 19:09:07

by Eric Paris

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the final tree (in Linus' tree)

On Fri, 2013-05-17 at 10:47 +0530, Viresh Kumar wrote:
> On Wed, May 15, 2013 at 7:02 PM, Eric Paris <[email protected]> wrote:
> > On Wed, 2013-05-15 at 13:20 +1000, Stephen Rothwell wrote:
> >> Hi ,
> >>
> >> After merging the final tree, today's linux-next build (i386 defconfig)
> >> produced this warning:
> >>
> >> kernel/auditfilter.c: In function 'audit_data_to_entry':
> >> kernel/auditfilter.c:426:3: warning: this decimal constant is unsigned only in ISO C90 [enabled by default]
> >>
> >> Introduced by commit 780a7654cee8 ("audit: Make testing for a valid
> >> loginuid explicit") from Linus' tree.
> >
> > Thank you, I'll fix it up. What am I likely missing that I don't see it
> > on my builds? I'm using gcc 4.8. Is there a config option that enables
> > additional warnings?
>
> Is this fixed? I couldn't find a relevant patch in linux-next/master for it.

Something should be posted by the end of the day. Sorry for the delay.