2013-05-21 02:43:42

by Libo Chen

Subject: [PATCH 15/19] drivers/net/irda: add missing platform_driver owner

set the owner of platform_driver, to ensure that the
caller of driver holds a module refernece

Signed-off-by: Libo Chen <[email protected]>
---
drivers/net/irda/bfin_sir.c | 1 +
drivers/net/irda/sh_irda.c | 1 +
drivers/net/irda/sh_sir.c | 1 +
drivers/net/irda/smsc-ircc2.c | 1 +
4 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/net/irda/bfin_sir.c b/drivers/net/irda/bfin_sir.c
index 22b4527..bf976f3 100644
--- a/drivers/net/irda/bfin_sir.c
+++ b/drivers/net/irda/bfin_sir.c
@@ -806,6 +806,7 @@ static struct platform_driver bfin_ir_driver = {
.resume = bfin_sir_resume,
.driver = {
.name = DRIVER_NAME,
+ .owner = THIS_MODULE,
},
};

diff --git a/drivers/net/irda/sh_irda.c b/drivers/net/irda/sh_irda.c
index 9448587..f14ea43 100644
--- a/drivers/net/irda/sh_irda.c
+++ b/drivers/net/irda/sh_irda.c
@@ -865,6 +865,7 @@ static struct platform_driver sh_irda_driver = {
.remove = sh_irda_remove,
.driver = {
.name = DRIVER_NAME,
+ .owner = THIS_MODULE,
.pm = &sh_irda_pm_ops,
},
};
diff --git a/drivers/net/irda/sh_sir.c b/drivers/net/irda/sh_sir.c
index 24aefcd..3bd058d 100644
--- a/drivers/net/irda/sh_sir.c
+++ b/drivers/net/irda/sh_sir.c
@@ -806,6 +806,7 @@ static struct platform_driver sh_sir_driver = {
.remove = sh_sir_remove,
.driver = {
.name = DRIVER_NAME,
+ .owner = THIS_MODULE,
},
};

diff --git a/drivers/net/irda/smsc-ircc2.c b/drivers/net/irda/smsc-ircc2.c
index aa05dad..5b3e4d2 100644
--- a/drivers/net/irda/smsc-ircc2.c
+++ b/drivers/net/irda/smsc-ircc2.c
@@ -260,6 +260,7 @@ static struct platform_driver smsc_ircc_driver = {
.resume = smsc_ircc_resume,
.driver = {
.name = SMSC_IRCC2_DRIVER_NAME,
+ .owner = THIS_MODULE,
},
};

--
1.7.1

2013-05-21 13:09:39

by Sergei Shtylyov

Subject: Re: [PATCH 15/19] drivers/net/irda: add missing platform_driver owner

Hello.

On 21-05-2013 6:42, Libo Chen wrote:

> set the owner of platform_driver, to ensure that the
> caller of driver holds a module refernece

> Signed-off-by: Libo Chen <[email protected]>
> ---
> drivers/net/irda/bfin_sir.c | 1 +
> drivers/net/irda/sh_irda.c | 1 +
> drivers/net/irda/sh_sir.c | 1 +
> drivers/net/irda/smsc-ircc2.c | 1 +
> 4 files changed, 4 insertions(+), 0 deletions(-)

> diff --git a/drivers/net/irda/bfin_sir.c b/drivers/net/irda/bfin_sir.c
> index 22b4527..bf976f3 100644
> --- a/drivers/net/irda/bfin_sir.c
> +++ b/drivers/net/irda/bfin_sir.c
> @@ -806,6 +806,7 @@ static struct platform_driver bfin_ir_driver = {
> .resume = bfin_sir_resume,
> .driver = {
> .name = DRIVER_NAME,
> + .owner = THIS_MODULE,

Either indent last = with space as above, or indent both = with tabs.

WBR, Sergei