2013-05-23 17:35:41

by Michel Machado

Subject: [PATCH 1/1] net-next: export skb_splice_bits()

skb_splice_bits() is already available in include/linux/skbuff.h, but
without EXPORT_SYMBOL it can't be used by kernel modules.

Signed-off-by: Michel Machado <[email protected]>
CC: "David S. Miller" <[email protected]>
CC: Eric Dumazet <[email protected]>
CC: Pravin B Shelar <[email protected]>
---
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index af9185d..0976908 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -1854,6 +1854,7 @@ done:

return ret;
}
+EXPORT_SYMBOL(skb_splice_bits);

/**
* skb_store_bits - store bits from kernel buffer to skb

2013-05-23 19:23:06

by David Miller

Subject: Re: [PATCH 1/1] net-next: export skb_splice_bits()

Ummm, no.

You don't export every single function just because it appears in a header
file.

When we have an in-kernel module that needs these functions, we can
export them, but no sooner.

So until you submit a set of changes that use these routines from modules
we're not exporting them.