2013-05-27 15:28:45

by Fabio Estevam

Subject: [PATCH] ARM: mxs: Include clk mxs header file

Fix the following sparse warnings:

drivers/clk/mxs/clk-imx28.c:72:5: warning: symbol 'mxs_saif_clkmux_select' was not declared. Should it be static?
drivers/clk/mxs/clk-imx28.c:156:12: warning: symbol 'mx28_clocks_init' was not declared. Should it be static?

Signed-off-by: Fabio Estevam <[email protected]>
---
drivers/clk/mxs/clk-imx28.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/mxs/clk-imx28.c b/drivers/clk/mxs/clk-imx28.c
index d0e5eed..4faf0af 100644
--- a/drivers/clk/mxs/clk-imx28.c
+++ b/drivers/clk/mxs/clk-imx28.c
@@ -10,6 +10,7 @@
*/

#include <linux/clk.h>
+#include <linux/clk/mxs.h>
#include <linux/clkdev.h>
#include <linux/err.h>
#include <linux/init.h>
--
1.8.1.2

2013-05-29 02:48:34

by Shawn Guo

Subject: Re: [PATCH] ARM: mxs: Include clk mxs header file

On Mon, May 27, 2013 at 12:28:25PM -0300, Fabio Estevam wrote:
> Fix the following sparse warnings:
>
> drivers/clk/mxs/clk-imx28.c:72:5: warning: symbol 'mxs_saif_clkmux_select' was not declared. Should it be static?
> drivers/clk/mxs/clk-imx28.c:156:12: warning: symbol 'mx28_clocks_init' was not declared. Should it be static?
>
> Signed-off-by: Fabio Estevam <[email protected]>

Acked-by: Shawn Guo <[email protected]>

> ---
> drivers/clk/mxs/clk-imx28.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/mxs/clk-imx28.c b/drivers/clk/mxs/clk-imx28.c
> index d0e5eed..4faf0af 100644
> --- a/drivers/clk/mxs/clk-imx28.c
> +++ b/drivers/clk/mxs/clk-imx28.c
> @@ -10,6 +10,7 @@
> */
>
> #include <linux/clk.h>
> +#include <linux/clk/mxs.h>
> #include <linux/clkdev.h>
> #include <linux/err.h>
> #include <linux/init.h>
> --
> 1.8.1.2
>
>