2013-05-29 07:30:22

by Paul Bolle

Subject: [PATCH] [TRIVIAL] Fix comment typo "CONFIG_PAE"

Signed-off-by: Paul Bolle <[email protected]>
---
Untested. Please note that I don't really understand this comment, but
the fix is correct anyhow.

drivers/lguest/page_tables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/lguest/page_tables.c b/drivers/lguest/page_tables.c
index 5b9ac32..a35d8d1 100644
--- a/drivers/lguest/page_tables.c
+++ b/drivers/lguest/page_tables.c
@@ -70,7 +70,7 @@
/*H:320
* The page table code is curly enough to need helper functions to keep it
* clear and clean. The kernel itself provides many of them; one advantage
- * of insisting that the Guest and Host use the same CONFIG_PAE setting.
+ * of insisting that the Guest and Host use the same CONFIG_X86_PAE setting.
*
* There are two functions which return pointers to the shadow (aka "real")
* page tables.
--
1.7.11.7

2013-05-30 05:34:40

by Rusty Russell

Subject: Re: [PATCH] [TRIVIAL] Fix comment typo "CONFIG_PAE"

Paul Bolle <[email protected]> writes:
> Signed-off-by: Paul Bolle <[email protected]>
> ---
> Untested. Please note that I don't really understand this comment, but
> the fix is correct anyhow.

Applied. And it just means that we can use the kernel (host) macros to
operate on the guest page tables, since they are both PAE or both
non-PAE.

Thanks!
Rusty.

> drivers/lguest/page_tables.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/lguest/page_tables.c b/drivers/lguest/page_tables.c
> index 5b9ac32..a35d8d1 100644
> --- a/drivers/lguest/page_tables.c
> +++ b/drivers/lguest/page_tables.c
> @@ -70,7 +70,7 @@
> /*H:320
> * The page table code is curly enough to need helper functions to keep it
> * clear and clean. The kernel itself provides many of them; one advantage
> - * of insisting that the Guest and Host use the same CONFIG_PAE setting.
> + * of insisting that the Guest and Host use the same CONFIG_X86_PAE setting.
> *
> * There are two functions which return pointers to the shadow (aka "real")
> * page tables.
> --
> 1.7.11.7