2013-05-30 09:04:50

by Kamalesh Babulal

Subject: [PATCH -tip] sched/fair: Remove unused variable from expire_cfs_rq_runtime()

78becc2709 "sched: Use an accessor to read the rq clock"
introduces rq_clock(), which obsoletes use of "rq" in
expire_cfs_rq_runtime() and triggers build warning:

kernel/sched/fair.c: In function 'expire_cfs_rq_runtime':
kernel/sched/fair.c:2159:13: warning: unused variable 'rq' [-Wunused-variable]

Signed-off-by: Kamalesh Babulal <[email protected]>
---
kernel/sched/fair.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 3ee1c2e..143dcdb 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2156,7 +2156,6 @@ static int assign_cfs_rq_runtime(struct cfs_rq *cfs_rq)
static void expire_cfs_rq_runtime(struct cfs_rq *cfs_rq)
{
struct cfs_bandwidth *cfs_b = tg_cfs_bandwidth(cfs_rq->tg);
- struct rq *rq = rq_of(cfs_rq);

/* if the deadline is ahead of our clock, nothing to do */
if (likely((s64)(rq_clock(rq_of(cfs_rq)) - cfs_rq->runtime_expires) < 0))
--
1.7.11.6

2013-05-30 09:20:47

by Frederic Weisbecker

Subject: Re: [PATCH -tip] sched/fair: Remove unused variable from expire_cfs_rq_runtime()

2013/5/30 Kamalesh Babulal <[email protected]>:
> 78becc2709 "sched: Use an accessor to read the rq clock"
> introduces rq_clock(), which obsoletes use of "rq" in
> expire_cfs_rq_runtime() and triggers build warning:
>
> kernel/sched/fair.c: In function 'expire_cfs_rq_runtime':
> kernel/sched/fair.c:2159:13: warning: unused variable 'rq' [-Wunused-variable]
>
> Signed-off-by: Kamalesh Babulal <[email protected]>

Thanks!

Acked-by: Frederic Weisbecker <[email protected]>

2013-05-30 14:02:07

by Paul Turner

Subject: Re: [PATCH -tip] sched/fair: Remove unused variable from expire_cfs_rq_runtime()

Looks good

On Thu, May 30, 2013 at 2:20 AM, Frederic Weisbecker <[email protected]> wrote:
> 2013/5/30 Kamalesh Babulal <[email protected]>:
>> 78becc2709 "sched: Use an accessor to read the rq clock"
>> introduces rq_clock(), which obsoletes use of "rq" in
>> expire_cfs_rq_runtime() and triggers build warning:
>>
>> kernel/sched/fair.c: In function 'expire_cfs_rq_runtime':
>> kernel/sched/fair.c:2159:13: warning: unused variable 'rq' [-Wunused-variable]
>>
>> Signed-off-by: Kamalesh Babulal <[email protected]>
>
> Thanks!
>
> Acked-by: Frederic Weisbecker <[email protected]>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2013-05-31 12:45:01

by tip-bot for Vasyl Gomonovych

Subject: [tip:sched/core] sched/fair: Remove unused variable from expire_cfs_rq_runtime()

Commit-ID: 0de358f1c2642710d41190b73fbc295e675c4ab8
Gitweb: http://git.kernel.org/tip/0de358f1c2642710d41190b73fbc295e675c4ab8
Author: Kamalesh Babulal <[email protected]>
AuthorDate: Thu, 30 May 2013 14:34:20 +0530
Committer: Ingo Molnar <[email protected]>
CommitDate: Fri, 31 May 2013 13:02:29 +0200

sched/fair: Remove unused variable from expire_cfs_rq_runtime()

Commit 78becc2709 ("sched: Use an accessor to read the rq clock")
introduces rq_clock(), which obsoletes the use of the "rq" variable
in expire_cfs_rq_runtime() and triggers this build warning:

kernel/sched/fair.c: In function 'expire_cfs_rq_runtime':
kernel/sched/fair.c:2159:13: warning: unused variable 'rq' [-Wunused-variable]

Signed-off-by: Kamalesh Babulal <[email protected]>
Acked-by: Frederic Weisbecker <[email protected]>
Acked-by: Paul Turner <[email protected]>
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
---
kernel/sched/fair.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 3ee1c2e..143dcdb 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2156,7 +2156,6 @@ static int assign_cfs_rq_runtime(struct cfs_rq *cfs_rq)
static void expire_cfs_rq_runtime(struct cfs_rq *cfs_rq)
{
struct cfs_bandwidth *cfs_b = tg_cfs_bandwidth(cfs_rq->tg);
- struct rq *rq = rq_of(cfs_rq);

/* if the deadline is ahead of our clock, nothing to do */
if (likely((s64)(rq_clock(rq_of(cfs_rq)) - cfs_rq->runtime_expires) < 0))

2013-05-31 15:59:03

by Peter Zijlstra

Subject: Re: [PATCH -tip] sched/fair: Remove unused variable from expire_cfs_rq_runtime()

On Thu, May 30, 2013 at 02:34:20PM +0530, Kamalesh Babulal wrote:
> 78becc2709 "sched: Use an accessor to read the rq clock"
> introduces rq_clock(), which obsoletes use of "rq" in
> expire_cfs_rq_runtime() and triggers build warning:
>
> kernel/sched/fair.c: In function 'expire_cfs_rq_runtime':
> kernel/sched/fair.c:2159:13: warning: unused variable 'rq' [-Wunused-variable]
>
> Signed-off-by: Kamalesh Babulal <[email protected]>

Thanks!